Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request new vs-code LSP #77

Closed
tilupe opened this issue Nov 6, 2023 · 1 comment
Closed

Feature Request new vs-code LSP #77

tilupe opened this issue Nov 6, 2023 · 1 comment

Comments

@tilupe
Copy link

tilupe commented Nov 6, 2023

Hello,

First of all thank you for this amazing project and the constant updates. I appreciated this project since the beginning.
I am not sure if you heard of the new Language-Server(LS) from Microsoft which they include in their new C#-Dev-Kit in VS-Code.

The LS should be and stay open-source and they worked also together with the maintainers of omnisharp. I think the future is leaning towards this new LS and it is also amazing how much faster it is already.
There is still some work to be done, especially in the integration into neovim. But I thought it could be good if this project will also be able to support this new LS.
I guess basically it shouldn't matter what LS is behind for this project, but I tried one time to run some tests and it didn't find any...

So maybe it is just a small adaptation or maybe it's more work. But I wanted to ask if it would be possible to check it out, such that if the LS is more mature in neovim it will already be compatible with this project.

To follow the development it is easiest to follow this issue and there is also described how to get the new LS running. Besides a few tweaks it went quite painless for me.

Thank you

@Issafalcon
Copy link
Owner

Hi @timotESC . Thanks for the appreciation!

Whilst it would be great if we could use a language server in this adapter, the core neotest plugin works mainly through treesitter and it's API, and as such, so do the adapters.

I don't leverage any LSP's in the adapter (although I did to begin with when starting this adapter, but it was just not worth it, and only gave limited information that was relevant to locating tests), so a new language server really wouldn't be something that would have any bearing on this project.

However, thanks for making a suggestion and pointing me towards something shiny to investigate!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants