From 249a434bb00e24197178004ee54345bf07b8583f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jan=20K=C5=99enek?= Date: Wed, 7 Sep 2022 12:19:26 +0200 Subject: [PATCH] Fix email notification from schedulers --- .../PbsPro/Generic/ConversionAdapter/PbsProJobAdapter.cs | 4 ++-- .../Slurm/Generic/ConversionAdapter/SlurmJobAdapter.cs | 4 ++-- README.md | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/HpcConnectionFramework/SchedulerAdapters/PbsPro/Generic/ConversionAdapter/PbsProJobAdapter.cs b/HpcConnectionFramework/SchedulerAdapters/PbsPro/Generic/ConversionAdapter/PbsProJobAdapter.cs index ef8533f..d73ed90 100644 --- a/HpcConnectionFramework/SchedulerAdapters/PbsPro/Generic/ConversionAdapter/PbsProJobAdapter.cs +++ b/HpcConnectionFramework/SchedulerAdapters/PbsPro/Generic/ConversionAdapter/PbsProJobAdapter.cs @@ -58,8 +58,8 @@ public void SetTasks(IEnumerable tasksAllocationcmd) /// Notification on failured job public void SetNotifications(string mailAddress, bool? notifyOnStart, bool? notifyOnCompletion, bool? notifyOnFailure) { - if (!string.IsNullOrEmpty(mailAddress) && (notifyOnStart ?? false) - || (notifyOnCompletion ?? false) || (notifyOnFailure ?? false)) + if (!string.IsNullOrEmpty(mailAddress) && ((notifyOnStart ?? false) + || (notifyOnCompletion ?? false) || (notifyOnFailure ?? false))) { var onFailureValue = (notifyOnFailure ?? false ? "a" : string.Empty); var onStartValue = (notifyOnStart ?? false ? "b" : string.Empty); diff --git a/HpcConnectionFramework/SchedulerAdapters/Slurm/Generic/ConversionAdapter/SlurmJobAdapter.cs b/HpcConnectionFramework/SchedulerAdapters/Slurm/Generic/ConversionAdapter/SlurmJobAdapter.cs index e0d4568..24aa1d1 100644 --- a/HpcConnectionFramework/SchedulerAdapters/Slurm/Generic/ConversionAdapter/SlurmJobAdapter.cs +++ b/HpcConnectionFramework/SchedulerAdapters/Slurm/Generic/ConversionAdapter/SlurmJobAdapter.cs @@ -58,8 +58,8 @@ public void SetTasks(IEnumerable tasksAllocationcmd) /// Notification on failured job public void SetNotifications(string mailAddress, bool? notifyOnStart, bool? notifyOnCompletion, bool? notifyOnFailure) { - if (!string.IsNullOrEmpty(mailAddress) && (notifyOnStart ?? false) - || (notifyOnCompletion ?? false) || (notifyOnFailure ?? false)) + if (!string.IsNullOrEmpty(mailAddress) && ((notifyOnStart ?? false) + || (notifyOnCompletion ?? false) || (notifyOnFailure ?? false))) { string mailParameters = string.Empty; if (notifyOnFailure ?? false) diff --git a/README.md b/README.md index fff1993..1c8d2ff 100644 --- a/README.md +++ b/README.md @@ -22,7 +22,7 @@ Major changes in the latest release includes - various functional and security updates ## Documentation -Please see the official HEAppE documentation at https://heappe.eu/docs. +Please see the official HEAppE documentation at https://heappe.it4i.cz/docs. # References