From 10e32fd3801d596f0620830a63ecbf51af125172 Mon Sep 17 00:00:00 2001
From: GDN <96800819+GDNgit@users.noreply.github.com>
Date: Wed, 8 May 2024 20:14:33 -0500
Subject: [PATCH] fixes particle holders not naturally gcing (#25438)

---
 code/game/objects/effects/effects.dm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/code/game/objects/effects/effects.dm b/code/game/objects/effects/effects.dm
index 2a7267b881d3..cbf3f46175af 100644
--- a/code/game/objects/effects/effects.dm
+++ b/code/game/objects/effects/effects.dm
@@ -159,7 +159,7 @@
 	///typepath of the last location we're in, if it's different when moved then we need to update vis contents
 	var/last_attached_location_type
 	/// The main item we're attached to at the moment, particle holders hold particles for something
-	var/atom/parent
+	var/atom/movable/parent
 	/// The mob that is holding our item
 	var/mob/holding_parent
 
@@ -181,6 +181,7 @@
 	if(parent)
 		UnregisterSignal(parent, list(COMSIG_MOVABLE_MOVED, COMSIG_PARENT_QDELETING))
 	QDEL_NULL(particles)
+	parent.vis_contents -= src
 	return ..()
 
 ///signal called when parent is moved
@@ -192,6 +193,7 @@
 ///signal called when parent is deleted
 /obj/effect/abstract/particle_holder/proc/on_qdel(atom/movable/attached, force)
 	SIGNAL_HANDLER
+	attached.vis_contents -= src
 	qdel(src)//our parent is gone and we need to be as well
 
 ///logic proc for particle holders, aka where they move.