Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Notification dot/indicator #46

Open
ItsSim opened this issue Aug 14, 2022 · 1 comment
Open

[Feature] Notification dot/indicator #46

ItsSim opened this issue Aug 14, 2022 · 1 comment
Labels
enhancement New feature or request feature accepted Feature has been accepted good first issue Good for newcomers help wanted Extra attention is needed low priority Low priority
Milestone

Comments

@ItsSim
Copy link
Owner

ItsSim commented Aug 14, 2022

Is your feature request related to a problem? Please describe.
When (for example) the remesh package is updated, the user has no way of knowing it was updated without checking the installer tab periodically.

Describe the solution you'd like
There should be a way to set a notification dot or indicator for any tab in the launcher. Adding a notification dot to the sidebar would promptly let the user know that they should check out the tab.

Additional context

Implementation
  • Add a js function in fsolauncher_ui/client.js to set a notification dot, passing in the tab id as a parameter. The notification dot should automatically be dismissed when the user enters said tab.
  • Add an ipc-bridge method in fsolauncher/library/ipc-bridge.js and its handler in fsolauncher_ui/client.js so that a notification dot can be set from the node.js side.
  • Use the ipc-bridge method to set a notification dot on the Installer tab any time there is a new remesh update.
  • Keep track of notification dots that have already been dismissed, using localStorage in fsolauncher_ui/client.js. Use remesh package version to identify if a notification dot has already been dismissed for that particular version.
Example notification dot on the installer tab, in the sidebar:

image

@ItsSim ItsSim added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers low priority Low priority feature accepted Feature has been accepted labels Aug 14, 2022
@ItsSim ItsSim added this to the 1.10 milestone Jul 29, 2023
@ItsSim ItsSim changed the title [Windows/Mac] Notification dot/indicator [All platforms] Notification dot/indicator Apr 3, 2024
@ItsSim ItsSim changed the title [All platforms] Notification dot/indicator Notification dot/indicator Apr 3, 2024
@ItsSim ItsSim modified the milestones: 1.10.x, 1.13.x Jun 10, 2024
@ItsSim
Copy link
Owner Author

ItsSim commented Jun 17, 2024

Instead of the complex dot indicator state, a better approach would be:

  • Use localStorage to store the last time the user has accessed the Installer tab.

  • If it's been > 24hr (which is when the "new remesh pack available" status expires) and there is currently a remesh available, show the dot indicator.

  • When the user clicks the Installer tab, save the current timestamp and hide the dot.

@ItsSim ItsSim changed the title Notification dot/indicator [Feature] Notification dot/indicator Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature accepted Feature has been accepted good first issue Good for newcomers help wanted Extra attention is needed low priority Low priority
Projects
None yet
Development

No branches or pull requests

1 participant