Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bracketed choices which don't have content before their brackets error when a subsequently nested third-level choice is encountered #66

Closed
LilithSilver opened this issue Dec 14, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@LilithSilver
Copy link
Contributor

LilithSilver commented Dec 14, 2023

This one's SUPER specific, but:


-> content
== content

*	Some choice
	blah blah 
	blah blah blah
*	*	[This is the killer!] Text can be here though, just not on the left.
		Blah blah
		Something something
*	*	*	Encountering this choice causes an error.
-	Weave...
-> DONE

The error is "Stack is empty! No top()!" from _container.top() on line 1176 of runner_impl.cpp:

			case Command::END_CONTAINER_MARKER:
			{
				container_t index = read<container_t>();
				inkAssert(_container.top().id == index, "Leaving container we are not in!");

				// Move up out of the current container
				_container.pop();

Unit test here. This occurs on MSVC regardless of configuration (Release or Debug).

I tried it on #65, but it's still broken there, so this is unrelated to #63.

Note that it is required to be in a knot; it doesn't occur at the top level.

@JBenda JBenda added the bug Something isn't working label Dec 14, 2023
@JBenda
Copy link
Owner

JBenda commented Dec 14, 2023

Thank you for catching it. There was a shortcut in the jump routine which resulted in errors. It is disabled for now. (also part of #65)

@JBenda JBenda closed this as completed in e55613b Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants