Added alpha-beta projection to cubed sphere. #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odlomax
requested review from
wdeconinck,
ss421,
MarekWlasak,
twsearle and
KrissyRayD242
Codecov Report
@@ Coverage Diff @@
## feature/cubed-sphere-base2 #87 +/- ##
==============================================================
+ Coverage 77.59% 78.00% +0.40%
==============================================================
Files 756 758 +2
Lines 51297 52733 +1436
==============================================================
+ Hits 39804 41133 +1329
- Misses 11493 11600 +107
Continue to review full report at Codecov.
|
MarekWlasak
reviewed
Jan 27, 2022
MarekWlasak
reviewed
Jan 27, 2022
MarekWlasak
reviewed
Jan 27, 2022
MarekWlasak
requested changes
Feb 1, 2022
The |
MarekWlasak
approved these changes
Feb 2, 2022
wdeconinck
pushed a commit
that referenced
this pull request
Feb 4, 2022
wdeconinck
added a commit
that referenced
this pull request
Feb 4, 2022
* develop: (21 commits) Add new yml file for variable resolution projection To run the update_uid.py under linux I should add the option shell=True in Popen Make VortexRollup function publicly available, and remove it from various places (#87) More testing and implementations for VariableResolutionProjection (#89) Fixup PointXYZ operator /= to be bitreproducible with PointXYZ::div Add *= and /= operators to PointXYZ with scalar ATLAS-345 Use new eckit::linalg::LinearAlgebraSparse and eckit::linalg::LinearAlgebraDense API (see ECKIT-585) Prevent optimisation with NVHPC compiler in VariableResolutionProjection Adapt atlas_test_field_missingvalue as there is no standard on comparisons with NaN Workaround for Cray 8.7 compiler bug resulting in FE_DIVBYZERO in atlas_test_jacobian in Release build ATLAS-327 Workaround for Cray 8.7 compiler bug with CXX flags "-O2 -hfp1 -g -DNDEBUG" Fixup previous commit Allow use of build_cells_remote_index() when halo was already built Apply clang-format Addressed reviewer comments. Permitted variable sized halos on functionspaces. Added ghost field to CubedSphereCellColumns functionspace. ATLAS-344 Fix atlas_test_healpixmeshgen CI with nvhpc-21.9 ATLAS-344 Fix MatchingMeshPartitionerLonLatPolygon to work with non-matching domains ATLAS-344 PolygonXY with Point2 member variables ATLAS-344 Printing of util::PolygonCoordinates ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR predominantly adds an
(x, y)to(alpha, beta)projection for tilet. Here,(alpha, beta)is defined strictly as the angular coordinates described by Ronchi et al., (1996).In practice, the transform is a simple shift and rotate for
xycoordinates internal to tilet. A non-linear stretch is applied for external points (i.e. haloxycoordinates).The following example considers tile
t=0of the LFRic cubed sphere dual mesh, withhalo = 3. The first image shows thexyprojection. The second image gives the(alpha, beta)projection.This required changes to several classes, summarised as follows:
tileCenterandtileJacobianwhich return thexycentre andd_xy/d_alphabetaJacobian for each tile.utilnamespace.Tilesmethods. This minor refactoring therefore serves as a test for the changes.CubedSphereProjectionBaserank <= 3constraint. Not related to projection, but it was an easy fix.This transform is currently only implemented for the equiangular cubedsphere projection. It is also likely that I've introduced some unnecessary redundancy to the
CubedSphereProjectionBaseandTilesclasses. However, given that we intend to refactor the cubed sphere grid at some point, we'll eventually need to refactor these classes too.@wdeconinck
Given that this branch and
feature/cubed_sphere_halo_modificationboth relate to halos, it probably makes sense to merge the two for the upstream PR.closes #81