Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] ConcurrentModificationException with EventWaiter #60

Open
4 of 6 tasks
Shengaero opened this issue Mar 26, 2018 · 0 comments
Open
4 of 6 tasks

[Bug] ConcurrentModificationException with EventWaiter #60

Shengaero opened this issue Mar 26, 2018 · 0 comments
Labels
Bug A bug, error, and/or oversight in the code-base. Module: Commons Related to the "commons" module. Version: 2.2
Milestone

Comments

@Shengaero
Copy link
Collaborator

Shengaero commented Mar 26, 2018

Issue

Issue Checklist

Please follow the following steps before opening this issue.

Issues that do not complete the checklist may be closed without any help.

  • I have checked for similar issues on the issue tracker.
  • I have updated to the latest version of JDA-Utilities.
  • I have checked the branches or the maintainers' PRs for upcoming features/bug fixes.

The issue tracker is reserved for issues, errors, and feature requests related
to JDA-Utilities, and not questions and other requests for help.

Issue Information

Check all that apply:

  • This is a bug report about an error, issue, or bug in JDA-Utilities.
    • I have been able to consistently reproduce this bug.
  • This is a feature request for the JDA-Utilities library.

This issue tracker does not assist or handle issues with the JDA library.

For JDA related issues, visit the JDA issue tracker
and open an issue there.

Description

I am opening this issue after closing #57 as it will require a proper fix and not a simple 2 line patch.

As was previously stated in that PR, EventWaiter is currently not thread safe.

java.util.ConcurrentModificationException: null
    at java.util.HashMap$HashIterator.nextNode(HashMap.java:1442)
    at java.util.HashMap$KeyIterator.next(HashMap.java:1466)
    at java.util.AbstractCollection.toArray(AbstractCollection.java:196)
    at com.jagrosh.jdautilities.commons.waiter.EventWaiter.onEvent(EventWaiter.java:239)
@Shengaero Shengaero added Bug A bug, error, and/or oversight in the code-base. Module: Commons Related to the "commons" module. Version: 2.2 labels Mar 26, 2018
@Shengaero Shengaero added this to the Version 2.2 milestone Mar 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug, error, and/or oversight in the code-base. Module: Commons Related to the "commons" module. Version: 2.2
Projects
None yet
Development

No branches or pull requests

1 participant