Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diversifying prompt-selection #3

Open
natureyoo opened this issue Nov 11, 2022 · 2 comments
Open

Diversifying prompt-selection #3

natureyoo opened this issue Nov 11, 2022 · 2 comments

Comments

@natureyoo
Copy link

Thank you very much your pytorch implementation for L2P!
I have a question about prompt selection.
In the paper, they use prompt frequency based weight to select diverse prompt, but i think i can't find that part in the code.
I think I can't find that part not only in your code but also in the official jax-based code, so could you let me know if there's anything I'm missing?

Thank you very much for your work!!!

@pmy0792
Copy link

pmy0792 commented Nov 11, 2022

google-research/l2p#9

@JH-LEE-KR
Copy link
Owner

Hi,
thanks for your comment.

You're right. In the paper, they use frequency-based weight to select a diverse prompt.
I also could not find the explicit part in the official jax code, and could not implement.

According to a recent author's explanation (linked by @pmy0792 above), they implemented the method simply and effectively using config.use_prompt_mask.

Fortunately use_prompt_mask is already implemented in my code, and I think you can change this option to True and apply a method that selects a diverse prompt.

However, they said in paper that the method was applied only to 5-datasets, not Split-CIFAR100.
I recently implemented the PyTorch code for 5-datasets, and I updated it, so check it.

If you have any additional comments, please feel free to let me know.

Best,
Jaeho Lee.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants