Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for named group chats #20

Open
sabogalc opened this issue Aug 23, 2023 · 5 comments
Open

Add support for named group chats #20

sabogalc opened this issue Aug 23, 2023 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@sabogalc
Copy link

I have a group chat with two people that has a name and group chat photo. I used pypush to text these two people (made sure that the phone numbers and everything matched), and it made a new group chat rather than texting into the existing one.

@sabogalc
Copy link
Author

I didn't consider the fact that pypush is a completely new instance of my messages so it may not have access to my message history, and hence the group chats. If this is indeed the case, I am okay with this just being closed (I'll await confirmation from the dev(s)).

@korakoe
Copy link

korakoe commented Aug 25, 2023

Would still like to see this resolved for reducing friction between platforms

@TaeHagen
Copy link

TaeHagen commented Aug 29, 2023

If the chat is named or has a photo, it'll create a new one. Otherwise, it should use the existing one as long as you match the participant's handles exactly. Pypush does not have access to your message history, although that is not necessary to preserve group chats.

@korakoe
Copy link

korakoe commented Aug 29, 2023

How would one interact with names group chats then?

@TaeHagen
Copy link

you can't with pypush atm, you need to send the n field in the payload with the chat name. Possible if you'd like to add tho.

@JJTech0130 JJTech0130 added enhancement New feature or request good first issue Good for newcomers labels Sep 7, 2023
@JJTech0130 JJTech0130 changed the title Add support for group chats Add support for named group chats Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants