Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve handling of B classes in main solver #17

Open
JOThurgood opened this issue May 22, 2019 · 0 comments
Open

refactor: improve handling of B classes in main solver #17

JOThurgood opened this issue May 22, 2019 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@JOThurgood
Copy link
Owner

JOThurgood commented May 22, 2019

Importing the field-class module to the solver is arguably done in an odd way.

Might be better to simply take magnetic field object as an argument to the ray / swarm constructors , then save that object as a property of the ray. The field should then be available to the solver through a ray property rather than through a separate object in global scope.

Apart from cleaning up the code, for usage this would allow for easier handling of different B fields within the same script.

@JOThurgood JOThurgood added the enhancement New feature or request label May 22, 2019
@JOThurgood JOThurgood self-assigned this May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant