-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Improve search history by attaching change listener (#9794)
- Loading branch information
Showing
4 changed files
with
124 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
109 changes: 109 additions & 0 deletions
109
src/test/java/org/jabref/gui/search/GlobalSearchBarTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,109 @@ | ||
| package org.jabref.gui.search; | ||
|
|
||
| import java.util.EnumSet; | ||
| import java.util.List; | ||
|
|
||
| import javafx.scene.Scene; | ||
| import javafx.scene.control.TextInputControl; | ||
| import javafx.scene.layout.HBox; | ||
| import javafx.stage.Stage; | ||
|
|
||
| import org.jabref.gui.DialogService; | ||
| import org.jabref.gui.JabRefFrame; | ||
| import org.jabref.gui.StateManager; | ||
| import org.jabref.gui.undo.CountingUndoManager; | ||
| import org.jabref.gui.util.DefaultTaskExecutor; | ||
| import org.jabref.model.database.BibDatabaseContext; | ||
| import org.jabref.model.search.rules.SearchRules; | ||
| import org.jabref.preferences.PreferencesService; | ||
| import org.jabref.preferences.SearchPreferences; | ||
| import org.jabref.testutils.category.GUITest; | ||
|
|
||
| import org.junit.jupiter.api.Test; | ||
| import org.junit.jupiter.api.extension.ExtendWith; | ||
| import org.mockito.Answers; | ||
| import org.testfx.api.FxRobot; | ||
| import org.testfx.framework.junit5.ApplicationExtension; | ||
| import org.testfx.framework.junit5.Start; | ||
|
|
||
| import static org.junit.jupiter.api.Assertions.assertEquals; | ||
| import static org.junit.jupiter.api.Assertions.assertTrue; | ||
| import static org.mockito.Mockito.mock; | ||
| import static org.mockito.Mockito.when; | ||
|
|
||
| @GUITest | ||
| @ExtendWith(ApplicationExtension.class) | ||
| public class GlobalSearchBarTest { | ||
| private Stage stage; | ||
| private Scene scene; | ||
| private HBox hBox; | ||
|
|
||
| private GlobalSearchBar searchBar; | ||
| private StateManager stateManager; | ||
|
|
||
| @Start | ||
| public void onStart(Stage stage) { | ||
| SearchPreferences searchPreferences = mock(SearchPreferences.class); | ||
| when(searchPreferences.getSearchFlags()).thenReturn(EnumSet.noneOf(SearchRules.SearchFlags.class)); | ||
| PreferencesService prefs = mock(PreferencesService.class, Answers.RETURNS_DEEP_STUBS); | ||
| when(prefs.getSearchPreferences()).thenReturn(searchPreferences); | ||
|
|
||
| stateManager = new StateManager(); | ||
| // Need for active database, otherwise the searchField will be disabled | ||
| stateManager.setActiveDatabase(new BibDatabaseContext()); | ||
|
|
||
| // Instantiate GlobalSearchBar class, so the change listener is registered | ||
| searchBar = new GlobalSearchBar( | ||
| mock(JabRefFrame.class), | ||
| stateManager, | ||
| prefs, | ||
| mock(CountingUndoManager.class), | ||
| mock(DialogService.class) | ||
| ); | ||
|
|
||
| hBox = new HBox(searchBar); | ||
|
|
||
| scene = new Scene(hBox, 400, 400); | ||
| this.stage = stage; | ||
| stage.setScene(scene); | ||
|
|
||
| stage.show(); | ||
| } | ||
|
|
||
| @Test | ||
| void recordingSearchQueriesOnFocusLostOnly(FxRobot robot) throws InterruptedException { | ||
| stateManager.clearSearchHistory(); | ||
| String searchQuery = "Smith"; | ||
| // Track the node, that the search query will be typed into | ||
| TextInputControl searchField = robot.lookup("#searchField").queryTextInputControl(); | ||
|
|
||
| // The focus is on searchField node, as we click on the search box | ||
| var searchFieldRoboto = robot.clickOn(searchField); | ||
| for (char c : searchQuery.toCharArray()) { | ||
| searchFieldRoboto.write(String.valueOf(c)); | ||
| Thread.sleep(401); | ||
| assertTrue(stateManager.getWholeSearchHistory().isEmpty()); | ||
| } | ||
|
|
||
| // Set the focus to another node to trigger the listener and finally record the query. | ||
| DefaultTaskExecutor.runAndWaitInJavaFXThread(() -> hBox.requestFocus()); | ||
| List<String> lastSearchHistory = stateManager.getWholeSearchHistory().stream().toList(); | ||
|
|
||
| assertEquals(List.of("Smith"), lastSearchHistory); | ||
| } | ||
|
|
||
| @Test | ||
| void emptyQueryIsNotRecorded(FxRobot robot) { | ||
| stateManager.clearSearchHistory(); | ||
| String searchQuery = ""; | ||
| TextInputControl searchField = robot.lookup("#searchField").queryTextInputControl(); | ||
|
|
||
| var searchFieldRoboto = robot.clickOn(searchField); | ||
| searchFieldRoboto.write(searchQuery); | ||
|
|
||
| DefaultTaskExecutor.runAndWaitInJavaFXThread(() -> hBox.requestFocus()); | ||
| List<String> lastSearchHistory = stateManager.getWholeSearchHistory().stream().toList(); | ||
|
|
||
| assertEquals(List.of(), lastSearchHistory); | ||
| } | ||
| } |