Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not ask for Blender executable path if it is in %PATH% #71

Closed
TomasHubelbauer opened this issue May 20, 2020 · 2 comments
Closed

Do not ask for Blender executable path if it is in %PATH% #71

TomasHubelbauer opened this issue May 20, 2020 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@TomasHubelbauer
Copy link

Hi! I just started using this extension and I'd like to recommend and improvement which I think could be worthwhile: If Blender is in %PATH%, do not ask for the Blender executable path and use the one from path, or offer the Blender executable found in path as another option in the VS Code prompt shown after the Blender: Start command is executed for the first time.

I'll be interested in hearing what you think about this suggestion. The ###BLENDER_TEST### check should probably be done on the %PATH% executable just in case it isn't Blender and if the %PATH% Blender fails this check, the flow would fall back to the old one.

Let me know what you think, I'll be happy to work on this if you like the idea!

@Mateusz-Grzelinski Mateusz-Grzelinski added enhancement New feature or request good first issue Good for newcomers labels Aug 11, 2024
@Mateusz-Grzelinski
Copy link
Collaborator

Mateusz-Grzelinski commented Aug 11, 2024

Thats what I was playing around in #179 before I saw the comment.
Doing the ###BLENDER_TEST### might be pretty slow though, and i am wodering about caching...
Feel ffree to comment on PR.

@Mateusz-Grzelinski
Copy link
Collaborator

feature was released in version [0.0.22] - 2024-09-04, but some improvements can be made as described in #185

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants