Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make settings persistent between browser sessions #3

Open
JadeMaveric opened this issue Oct 14, 2020 · 4 comments
Open

Make settings persistent between browser sessions #3

JadeMaveric opened this issue Oct 14, 2020 · 4 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest

Comments

@JadeMaveric
Copy link
Owner

The keywords and interval applied are reset after each sessions. Most people, myself included, reuse the same keywords everytime. For some, this is quite a long list.

Most browsers have a way to make addon data persist between sessions. This shouldn't be very difficult to implement.

@JadeMaveric JadeMaveric added good first issue Good for newcomers enhancement New feature or request hacktoberfest labels Oct 14, 2020
@slytherin20
Copy link

Hi @JadeMaveric,
Can I work on this issue?

@JadeMaveric
Copy link
Owner Author

@slytherin20 Sure thing, go for it!

@slytherin20
Copy link

Hi @JadeMaveric,
I've been trying to run the temporary extension on my browser using web-ext CLI and I've been getting errors that I don't quite understand. I looked into the manifest.json file as well, nothing looked wrong.
Please take a look at the errors that I'm getting-
Screenshot_2020-10-18 Online Image Resizer - Crop, Resize Compress Images, Photos and Pictures for FREE

@JadeMaveric
Copy link
Owner Author

@slytherin20 "getClassname... is undefined". That's the line of code that handles fetching subtitles. In this case, there probably aren't any to find, so it's returning undefined. You'll have to handle that case.

It's also possible that the classname gmeet uses for subtitles has. But I think that's less probable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest
Projects
None yet
Development

No branches or pull requests

2 participants