-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix blank line cause silent quit. #145
Open
nomadalex
wants to merge
1
commit into
JakeWharton:master
Choose a base branch
from
nomadalex:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hmm should we actually continue here? Or display the blank line? |
It is completely blank line, it is unnecessary to display it. Blank which application output will not be completely blank. |
Then why was it logged?
…On Sun, Aug 6, 2017, 7:21 PM Kun Wang ***@***.***> wrote:
It is completely blank line, it is unnecessary to display it.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#145 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEEESSPiwLCxh47Vxn9JnjMNDIBtOx4ks5sVnS1gaJpZM4OubLq>
.
|
I don't know, but it exists, I found it on huawei honor 6, below is raw output with
|
hello? |
Hi, I reach the same problem with Huawei device and this PR fixes the silent quit. |
nicopico-dev
added a commit
to nicopico-dev/pidcat
that referenced
this pull request
Apr 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when logcat output blank line, pidcat will silent quit.