Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apple silicon support #1

Open
TravonteD opened this issue Dec 8, 2021 · 3 comments
Open

Apple silicon support #1

TravonteD opened this issue Dec 8, 2021 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@TravonteD
Copy link

Is your feature request related to a problem? Please describe.

The build script assumes that there is a labeled tar.gz for the architecture of the machine on the releases page in the janet project. Since one doesn't exist for mac-os arm this fails to download anything.

Describe the solution you'd like

When there is no pre-built tar, download the source code and build it from there.

@TravonteD TravonteD added the enhancement New feature or request label Dec 8, 2021
@Jakski
Copy link
Owner

Jakski commented Dec 16, 2021

@TravonteD Please provide a command you use to install Janet and its output. asdf-janet shouldn't take into account host's architecture, because it downloads source code from https://github.com/janet-lang/janet/archive/* and compiles it on target machine. Releases are also downloaded as a source code archives based on repository tags. For example currently asdf install janet latest should take archive from https://github.com/janet-lang/janet/archive/v1.19.2.tar.gz.

@TravonteD
Copy link
Author

Apologies for the the late reply, here is the raw output.

* Downloading janet v1.19.2...
~/.asdf/downloads/janet/1.19.2 ~
~/.asdf/downloads/janet/1.19.2/jpm ~/.asdf/downloads/janet/1.19.2 ~
~/.asdf/downloads/janet/1.19.2 ~
~
asdf-janet: Expected /Users/traydennis/.asdf/installs/janet/1.19.2/bin/janet to be executable.
asdf-janet: An error ocurred while installing janet 1.19.2.

The issue seems to be that the binaries don't exist in the directory. Running make from within the directory produced the executables libraries etc. in the build directory.

@Jakski Jakski added the help wanted Extra attention is needed label Jan 26, 2022
@Jakski
Copy link
Owner

Jakski commented Jan 26, 2022

Judging from output Janet isn't even compiled for some reason. make isn't involved in build process. meson generates files for ninja instead

meson setup build \

I've added continuous integration for latest MacOS(3eefdfa), but I couldn't replicate this issue in GitHub Actions. You can try installing dependencies brew install gcc ninja meson curl and then repeat installation with asdf. Unfortunately I don't own Apple Silicon and can't verify installation locally.

If someone's having the same issue with Apple Silicion and have some idea what can be wrong, then please share information in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants