Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

js/open-in-new-tab.js not loaded when on GH Pages with a subfolder #10

Open
ebouchut opened this issue Oct 28, 2024 · 0 comments · May be fixed by #11
Open

js/open-in-new-tab.js not loaded when on GH Pages with a subfolder #10

ebouchut opened this issue Oct 28, 2024 · 0 comments · May be fixed by #11

Comments

@ebouchut
Copy link

Description of the Issue

The plugin injects js/open-in-new-tab.js to the extra-javascript: section here

✅ This works fine locally: when using mkdocs serve where I can see the up-right arrow:

http://127.0.0.1:8000/

❌ However, this does not work, i.e. I cannot see the up-right arrow:
when deployed to my own GitHub Pages with mkdocs gh-deploy --force

https://ericbouchut.com/trio-docs/

Cause

The /js/open-in-new-tab.js file cannot be loaded (Error 404) because it is in /trio-docs/js/open-in-new-tab.js.

The items in extra_javascript have changed since Mkdocs version 1.5. This could be a clue.

Fix?

I tried to fix things in the plugin code (PR is underway).
The fix now works fine in both cases.

I need your guidance and a double pair of eyes.

@ebouchut ebouchut linked a pull request Oct 30, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant