Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle case of zero length notes created in formatters #101

Open
JamesOwers opened this issue Nov 26, 2019 · 2 comments
Open

Handle case of zero length notes created in formatters #101

JamesOwers opened this issue Nov 26, 2019 · 2 comments
Labels
bug Something isn't working design This pertains to design decisions

Comments

@JamesOwers
Copy link
Owner

TODO: This rounding may result in notes of length 0.

note_off = df.loc[:, ['onset', 'pitch']]

@JamesOwers JamesOwers added the bug Something isn't working label Nov 26, 2019
@JamesOwers JamesOwers added this to the Paper Camera-ready milestone Nov 26, 2019
JamesOwers added a commit that referenced this issue Nov 26, 2019
Issues now written to address later: #98, #99, #100, #101, #102
issues #103 #104 #105 #106 #107 and #108
@apmcleod
Copy link
Collaborator

We had mentioned that this might be fine (even though the note_off precedes the note_on--which is somewhat important). Any model should just learn that such a case corresponds to a very short note.

Otherwise, we can just not include such notes.

@apmcleod apmcleod added design This pertains to design decisions requires_discussion Either a large change or changes functionality - discuss/debate before implementation labels Nov 27, 2019
@JamesOwers
Copy link
Owner Author

We decided to force all notes to be at minimum length 1. This is because the command format is complicated by length zero notes i.e. note off followed by note on in the same time instance.

@JamesOwers JamesOwers removed the requires_discussion Either a large change or changes functionality - discuss/debate before implementation label Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working design This pertains to design decisions
Projects
None yet
Development

No branches or pull requests

2 participants