Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add optional flags for pip install such that users can optionally install pytorch etc. #91

Closed
JamesOwers opened this issue Nov 13, 2019 · 2 comments
Closed

Add optional flags for pip install such that users can optionally install pytorch etc. #91

JamesOwers opened this issue Nov 13, 2019 · 2 comments
Labels
enhancement New feature or request
Milestone
Dataset Public Re...

Comments

@JamesOwers
Copy link
Owner

Split up #65 such that I don't get stuck on this prior to ACME v1.0 creation
@JamesOwers JamesOwers added this to the Paper Camera-ready milestone Nov 13, 2019
@JamesOwers
Copy link
Owner Author

https://stackoverflow.com/questions/10572603/specifying-optional-dependencies-in-pypi-python-setup-py

I think all that needs to happen is to add:

setup(
    ...
    extras_require = {
        'all':  ["torch"]
    }
)

and then one can pip install .[all]

@apmcleod apmcleod mentioned this issue Nov 27, 2019
Open
@apmcleod apmcleod added the enhancement New feature or request label Nov 27, 2019
@JamesOwers
Copy link
Owner Author

Superseded by #131

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Dataset Public Release
Development

No branches or pull requests
2 participants
@JamesOwers @apmcleod