Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install_requires incomplete? #51

Open
pllim opened this issue Aug 15, 2022 · 1 comment
Open

install_requires incomplete? #51

pllim opened this issue Aug 15, 2022 · 1 comment

Comments

@pllim
Copy link
Contributor

pllim commented Aug 15, 2022

I see that in your CI workflow, you install a few more things than what is declared in your setup.py. Are they really needed? If so, they should be declared as install_requires or as optional dependencies in setup.py. Also see #47

- name: Checkout PyAutoConf
uses: actions/checkout@v2
with:
repository: rhayes777/PyAutoConf
path: PyAutoConf
- name: Checkout PyAutoFit
uses: actions/checkout@v2
with:
repository: rhayes777/PyAutoFit
path: PyAutoFit
- name: Checkout PyAutoArray
uses: actions/checkout@v2
with:
repository: Jammy2211/PyAutoArray
path: PyAutoArray

pip3 install -r PyAutoConf/requirements.txt
pip3 install -r PyAutoFit/requirements.txt
pip3 install -r PyAutoArray/requirements.txt
pip3 install -r PyAutoArray/optional_requirements.txt
pip3 install -r PyAutoGalaxy/requirements.txt

astropy/astropy.github.com#491 (comment)

@pllim
Copy link
Contributor Author

pllim commented Aug 15, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant