Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If Workspace is that important, why is it not in this repo? #63

Closed
pllim opened this issue Aug 15, 2022 · 2 comments
Closed

If Workspace is that important, why is it not in this repo? #63

pllim opened this issue Aug 15, 2022 · 2 comments

Comments

@pllim
Copy link
Contributor

pllim commented Aug 15, 2022

From https://pyautogalaxy.readthedocs.io/en/latest/general/workspace.html and throughout the documentation, it seems like autogalaxy workspace is an integral part of this package (not merely optional supplementary material?). If so, why not include it as part of this package? (Can always exclude from the manifest if you do not want it in the sdist tarball.)

astropy/astropy.github.com#491 (comment)

@pllim
Copy link
Contributor Author

pllim commented Aug 15, 2022

Related: If Workspace notebooks are indeed essential, consider adding Jupyter notebook installation instructions to the "conda" section of installation pages.

Or if you want to lock things down more, provide a conda environment YAML file.

@Jammy2211
Copy link
Owner

The primary reason is that the workspace contains notebooks and .fits datasets, which in the past have caused a lot of problems with bulking-out the repo history. By keeping them on a separate repo we avoid the source code history being noisy or (as was the case a long time ago) broken.

I also didn't find it much help having the workspace buried in the site-packages of an install.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants