Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Test against dev version of astropy (and other important upstream dependencies) #68

Open
pllim opened this issue Aug 15, 2022 · 0 comments

Comments

@pllim
Copy link
Contributor

pllim commented Aug 15, 2022

As far as I can tell, the CI is only pulling this for astropy:

astropy>=3.0.0

Which means you are only testing against the latest astropy release. Adding a test suite to test against development version of astropy would future-proof your code and prevent surprise on your end when new version of astropy is released.

If testing against dev is too much for you, at least test against pre-release (i.e., release candidate) when it is available (e.g., pip install astropy -U --pre).

Bonus: Also test against oldest version of important dependencies that you claim you support. For instance, I have doubt that your code really works for astropy 3.0 as you claim in your requirements file.

astropy/astropy.github.com#491 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant