Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to ensure updateHash is false when using select public method? #225

Open
oshihirii opened this issue Aug 20, 2016 · 3 comments
Open

Comments

@oshihirii
Copy link

It seems when I use the public method to select a particular tab, it starts updating the url on subsequent tab clicks even though easytabs is initialised with updateHash: false?

Initialised with:

$('#tab_container').easytabs({
updateHash: false
});

On click event contains:

$('#tab_container').easytabs('select', '#tab_1');

Can I pass through the updateHash parameter value in the public method call?

@oshihirii
Copy link
Author

Hmm, that problem seems to not be occurring anymore, will post back if it does or I figure out why it was happening.

@oshihirii
Copy link
Author

Actually would still be interested to know if this is possible.

The issue is occurring intermittently and I'm not able to create replicable steps yet, so would be good to know the above.

@oshihirii oshihirii reopened this Aug 20, 2016
@oshihirii
Copy link
Author

oshihirii commented Aug 20, 2016

Actually, I was able to replicate the problem.

If the plugin is not instantiated it will use the default options when using:

$('#tab_container').easytabs('select', '#tab_1');

So I just had to make sure that it has already been instantiated with:

$('#tab_container').easytabs({
updateHash: false
});

Before calling the method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant