-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arc not configured, preconfigure user/mail/author #432
Comments
@rugk Thanks a lot for reporting this issue! I'm not quite sure what went wrong. In theory, both You can check their values at https://janitor.technology/settings/ under the "Configurations" tab. Could you please verify that your name is correctly set up in your settings, and re-generate or fix these configuration files? (You can also re-deploy them to every container by using the link below the text area.) |
Ah, yeah, this is how it was configured: https://vim.cx/?ede76a907e4e4683#xhQN8H/HfALnn3/+eU/lxkBoQkbfaKtQWTXz4xfRabo= Thanks for the pointer, I could not adjust the files there, too, but I wonder why it did not initially configure it correctly. |
I suspect that's because Janitor can't know your real name when you sign in via email, so it leaves it blank unless you fill it manually. When you sign in with GitHub (you can do that from your "Integrations" settings), it should automatically fill in your full name if it's not already set. I think that enabling "Sign in with GitHub" generally for the Janitor web app could solve that problem. |
I think, I signed in with the mail variant it uses only, then it generated the config files, and only then I adjusted the name in the Janitor page and connected it with GitHub then. |
Yes, we don't automatically re-generate config files, because users might already have customized them, and we don't want to overwrite valuable changes. But maybe we could detect when config files are not customized, and overwrite them (or if they are customized, show a helpful warning to the user, and maybe a diff view between old a new config?) |
The trouble with the source code submission tools (ref #423), continues…
Now just before my patch was going to land someone noticed me that the diff does not have author info. No tool noticed me of this before!
see https://wiki.mozilla.org/Phabricator/FAQ#Lando
So, I guess this is the issue:
So can't we pre-configure this
.hgrc
file?The text was updated successfully, but these errors were encountered: