Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProjectPasskeys: Refactor MDS3 codebase and server config #9111

Closed
7 of 11 tasks
yackermann opened this issue Aug 5, 2024 · 6 comments
Closed
7 of 11 tasks

ProjectPasskeys: Refactor MDS3 codebase and server config #9111

yackermann opened this issue Aug 5, 2024 · 6 comments
Assignees

Comments

@yackermann
Copy link
Collaborator

yackermann commented Aug 5, 2024

Configuration refactoring

"disabled" means attestation "none"
"monitor" means attestation "direct" but still accept if none return
"enforced" means that credential creation will fail if attestation is not returned

@yackermann
Copy link
Collaborator Author

MDS Code Base refactoring

[TODO]

@yackermann yackermann changed the title ProjectPasskeys: Refactor MDS3 codebase ProjectPasskeys: Refactor MDS3 codebase and server config Aug 5, 2024
@yurem
Copy link
Contributor

yurem commented Aug 5, 2024

These 2 folders Fido2 uses for devices root certs:

Deprecate mdsCertsFolder
Deprecate authenticatorCertsFolder

Should we deprecate related to these folders functionality or there is replacement for this?

@yackermann
Copy link
Collaborator Author

There should not be a separate folder for device roots. All checks must be done against metadata @yurem

@yurem
Copy link
Contributor

yurem commented Aug 6, 2024

This is right approach. But how to do this edge cases if device not in MDS3 list yet? For example we also need to add SG roots.

@yackermann
Copy link
Collaborator Author

@yurem standard metadata will have the device root.

shekhar16 added a commit that referenced this issue Aug 26, 2024
shekhar16 added a commit that referenced this issue Aug 26, 2024
shekhar16 added a commit that referenced this issue Aug 26, 2024
@shekhar16 shekhar16 mentioned this issue Aug 26, 2024
yurem pushed a commit that referenced this issue Aug 27, 2024
* feat(jans-fido): refactor mds3 codebase and server config

Signed-off-by: shekhar16 <[email protected]>

* feat(jans-fido): revert rename from docker file #9111

Signed-off-by: shekhar16 <[email protected]>

* feat(jans-fido): add metadatarefreshinterval #9111

Signed-off-by: shekhar16 <[email protected]>

* feat(jans-fido): changes to refactor metadataservers #9111

Signed-off-by: shekhar16 <[email protected]>

---------

Signed-off-by: shekhar16 <[email protected]>
shekhar16 added a commit that referenced this issue Aug 31, 2024
@shekhar16 shekhar16 mentioned this issue Aug 31, 2024
shekhar16 added a commit that referenced this issue Sep 2, 2024
yurem pushed a commit that referenced this issue Sep 2, 2024
@shekhar16
Copy link
Contributor

I'm closing this ticket as all are done or having corresponding different tickets.

moabu pushed a commit that referenced this issue Nov 7, 2024
* feat(jans-fido): refactor mds3 codebase and server config

Signed-off-by: shekhar16 <[email protected]>

* feat(jans-fido): revert rename from docker file #9111

Signed-off-by: shekhar16 <[email protected]>

* feat(jans-fido): add metadatarefreshinterval #9111

Signed-off-by: shekhar16 <[email protected]>

* feat(jans-fido): changes to refactor metadataservers #9111

Signed-off-by: shekhar16 <[email protected]>

---------

Signed-off-by: shekhar16 <[email protected]>
moabu pushed a commit that referenced this issue Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants