-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Running example results in incostenties with timeouts and infinite loops #10
Comments
Hmmm could you find this file in your node_modules and comment this out:
if (!window.polymerSkipLoadingFontRoboto) {
// const link = document.createElement('link');
// link.rel = 'stylesheet';
// link.type = 'text/css';
// link.crossOrigin = 'anonymous';
// link.href =
// 'https://fonts.googleapis.com/css?family=Roboto+Mono:400,700|Roboto:400,300,300italic,400italic,500,500italic,700,700italic';
// document.head.appendChild(link);
} Does it make a difference if you re-run the test? |
I've pushed a fix to master to skip loading those fonts. |
In your node_modules is cypress-daywalker version |
Yep.
I've tried commenting out those lines inside
And the first and second run were all green! I wanted to rule out any luck, so I set out that it had to be all green for at least 10 runs. And sadly, on the third run things broke again. 4th run was all green, 5th run had 1 failing test, 6th and 7th run were all green, 8th run resulted in an infinite loop. All in all, it seems that not loading fonts shaves a bit of time off, making test results more green, but timeout problems still occur. The total running time is now just under 80 seconds when they pass. When they fail, they're just under 90. |
Please confirm if this is still the case with version |
Closing this issue. Tests are now succeeding consistently as per https://travis-ci.com/JaySunSyn/cypress-daywalker/builds/ Feel free to re-open. |
@JaySunSyn It took me a while, but I've tested it with version 0.2.1. Sadly, exactly the same results as before: inconsistent timeouts. I'd reopen, but can't if I didn't close it myself. |
I will now run the tests daily here https://travis-ci.com/JaySunSyn/cypress-daywalker/builds so we can check if tests fail once in a while but so far, they did not. I've also run them around 10 times locally just now and they succeed... I guess you did this:
correct? |
I'm truly curious what it could be, why it's so much slower on my machine and not on yours. Is it a software thing? A hardware thing? A Windows thing?
That, and then I noticed it installed 0.2.0 of your plugin, so I explicitly installed 0.2.1 and then ran |
Sorry for the late response, a bit busy here. But yep, I used And I have an SSD (Samsung PM981 512GB) and an NVIDIA GeForce MX130 video card as well as the Intel Integrated UHD Graphics. |
Hmm, shouldn't matter much. You can check out here how long the tests took to run on a travis runner https://travis-ci.com/JaySunSyn/cypress-daywalker/builds/127339626#L348 |
Since our back-and-forth yesterday in the Cypress repo, I'm now trying get the example specs to run properly. I hadn't updated Node.js yet yesterday, I've now done that as well. So I'm now running on the latest Node.js, Cypress and your plugin. This is what's happening for me when I run the example specs twice:
Timeouts, errors and the second run resulted in an infinite loop where the first run didn't. These are the exact steps I've taken:
Also, I noticed in your screen gif is that all tests take just under 15 seconds to complete, while one run for me takes over 90 seconds. I'm running on a high-end business laptop, it's a three month old Dell Latitude 5591 with 16GB RAM, 2.60GHz i7, SSD, all great specs. I don't understand the massive difference.
The text was updated successfully, but these errors were encountered: