Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alarm Module: Error setting alarm to today's date #22

Open
rbtylee opened this issue Jul 3, 2017 · 3 comments
Open

Alarm Module: Error setting alarm to today's date #22

rbtylee opened this issue Jul 3, 2017 · 3 comments

Comments

@rbtylee
Copy link
Collaborator

rbtylee commented Jul 3, 2017

Open module settings, click Add to add a date. In the Alarm Configuration: Setup window give the alarm a name and adjust Schedule. Under One Day click . Today. Now click either Test this alarm or Apply. An Alarm Module error message pops up:

Error, The alarm was not added!

The date you entered is before now.

alt text

@rbtylee
Copy link
Collaborator Author

rbtylee commented Jul 4, 2017

Ok closely examining the code, I have determined all functions are working as expected. What is going on is a confusing User Interface. When I clicked Today I was thinking Schedule would set the alarm hours and minutes from NOW. Instead it is setting the Alarm hours and minutes from the beginning of today. SO if it is 6 am and I want the alarm to go off in 15 minutes then I would have to set the hour to 6 and the minutes to 15. Not very convenient for a typical user case where you are cooking something and using the alarm as a timer. Imagine the time is 6:48 pm, then I would have to set the hours to 19, and the minutes to 3 corresponding to 7:03 pm. Do you really want our users to have to do arithmetic Modulo 24 and Modulo 60 to be able to handle such a typical user case?

I propose a change in user interface, but would like some feedback on this.

@thewaiter
Copy link
Collaborator

thewaiter commented Jul 4, 2017

What about adding the timer feature if we want to use it as cooking alarm?
Hard to say how many people use this module and if they will appreciate our effort...

@rbtylee
Copy link
Collaborator Author

rbtylee commented Jun 7, 2018

Ran into this issue again today seems no one has addressed it :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants