Skip to content

Commit 11afeab

Browse files
authored
Fix CMD_SCREEN_ON constant in accordance with #323 (#325)
* Fix CMD_SCREEN_ON constant in accordance with #323 * Format constants.py with black * Update constant in unittest
1 parent b1425b1 commit 11afeab

File tree

2 files changed

+7
-9
lines changed

2 files changed

+7
-9
lines changed

androidtv/constants.py

+1-3
Original file line numberDiff line numberDiff line change
@@ -177,9 +177,7 @@ class DeviceEnum(IntEnum):
177177
CMD_INSTALLED_APPS = "pm list packages"
178178

179179
#: Determine if the device is on
180-
CMD_SCREEN_ON = (
181-
"(dumpsys power | grep 'Display Power' | grep -q 'state=ON' || dumpsys power | grep -q 'mScreenOn=true')"
182-
)
180+
CMD_SCREEN_ON = "(dumpsys power | grep 'Display Power' | grep -q 'state=ON' || dumpsys power | grep -q 'mScreenOn=true' || dumpsys display | grep -q 'mScreenState=ON')"
183181

184182
#: Get the "STREAM_MUSIC" block from ``dumpsys audio``
185183
CMD_STREAM_MUSIC = r"dumpsys audio | grep '\- STREAM_MUSIC:' -A 11"

tests/test_constants.py

+6-6
Original file line numberDiff line numberDiff line change
@@ -185,13 +185,13 @@ def test_constants(self):
185185
# CMD_SCREEN_ON
186186
self.assertCommand(
187187
constants.CMD_SCREEN_ON,
188-
r"(dumpsys power | grep 'Display Power' | grep -q 'state=ON' || dumpsys power | grep -q 'mScreenOn=true')",
188+
r"(dumpsys power | grep 'Display Power' | grep -q 'state=ON' || dumpsys power | grep -q 'mScreenOn=true' || dumpsys display | grep -q 'mScreenState=ON')",
189189
)
190190

191191
# CMD_SCREEN_ON_AWAKE_WAKE_LOCK_SIZE
192192
self.assertCommand(
193193
constants.CMD_SCREEN_ON_AWAKE_WAKE_LOCK_SIZE,
194-
r"(dumpsys power | grep 'Display Power' | grep -q 'state=ON' || dumpsys power | grep -q 'mScreenOn=true') && echo -e '1\c' || echo -e '0\c' && dumpsys power | grep mWakefulness | grep -q Awake && echo -e '1\c' || echo -e '0\c' && dumpsys power | grep Locks | grep 'size='",
194+
r"(dumpsys power | grep 'Display Power' | grep -q 'state=ON' || dumpsys power | grep -q 'mScreenOn=true' || dumpsys display | grep -q 'mScreenState=ON') && echo -e '1\c' || echo -e '0\c' && dumpsys power | grep mWakefulness | grep -q Awake && echo -e '1\c' || echo -e '0\c' && dumpsys power | grep Locks | grep 'size='",
195195
)
196196

197197
# CMD_SERIALNO
@@ -203,25 +203,25 @@ def test_constants(self):
203203
# CMD_TURN_OFF_ANDROIDTV
204204
self.assertCommand(
205205
constants.CMD_TURN_OFF_ANDROIDTV,
206-
r"(dumpsys power | grep 'Display Power' | grep -q 'state=ON' || dumpsys power | grep -q 'mScreenOn=true') && input keyevent 26",
206+
r"(dumpsys power | grep 'Display Power' | grep -q 'state=ON' || dumpsys power | grep -q 'mScreenOn=true' || dumpsys display | grep -q 'mScreenState=ON') && input keyevent 26",
207207
)
208208

209209
# CMD_TURN_OFF_FIRETV
210210
self.assertCommand(
211211
constants.CMD_TURN_OFF_FIRETV,
212-
r"(dumpsys power | grep 'Display Power' | grep -q 'state=ON' || dumpsys power | grep -q 'mScreenOn=true') && input keyevent 223",
212+
r"(dumpsys power | grep 'Display Power' | grep -q 'state=ON' || dumpsys power | grep -q 'mScreenOn=true' || dumpsys display | grep -q 'mScreenState=ON') && input keyevent 223",
213213
)
214214

215215
# CMD_TURN_ON_ANDROIDTV
216216
self.assertCommand(
217217
constants.CMD_TURN_ON_ANDROIDTV,
218-
r"(dumpsys power | grep 'Display Power' | grep -q 'state=ON' || dumpsys power | grep -q 'mScreenOn=true') || input keyevent 26",
218+
r"(dumpsys power | grep 'Display Power' | grep -q 'state=ON' || dumpsys power | grep -q 'mScreenOn=true' || dumpsys display | grep -q 'mScreenState=ON') || input keyevent 26",
219219
)
220220

221221
# CMD_TURN_ON_FIRETV
222222
self.assertCommand(
223223
constants.CMD_TURN_ON_FIRETV,
224-
r"(dumpsys power | grep 'Display Power' | grep -q 'state=ON' || dumpsys power | grep -q 'mScreenOn=true') || (input keyevent 26 && input keyevent 3)",
224+
r"(dumpsys power | grep 'Display Power' | grep -q 'state=ON' || dumpsys power | grep -q 'mScreenOn=true' || dumpsys display | grep -q 'mScreenState=ON') || (input keyevent 26 && input keyevent 3)",
225225
)
226226

227227
# CMD_VERSION

0 commit comments

Comments
 (0)