-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fire TV Select source doesn't work right after "POWER" ADB command #194
Comments
It means wake up with POWER command when the fire TV is in idle state. |
Are you using an ADB server or the Python ADB implementation? Does the media player in HA become unavailable when this happens?
When you say "remote controller" I assume you're talking about a physical remote controller, not a remote that you created in Lovelace. What if instead of hitting a button on the remote, you just wait a few seconds? Does it work then? I bet you have the screencap option enabled. In some testing I did, retrieving the screencap can take a second or two. The timeout for ADB commands is 3 seconds, so if you send the power command, then HA tries to take a screencap and it takes 3+ seconds, your select source command will not get executed and you'll get that log message. |
Actually, I tested both ADB server and python ADB implementation both, and the results are same.
No, It's not unavailable, I can see status of media_player Even if I don't use Media control Card at all, the situation is the same. Yeah, the log is a little bit confusing. |
Depending on the device and the app you're trying to open, And keep in mind that if you bombard the device with commands that take some time, eventually a command won't get run within 3 seconds from the time that you tried to send it and you'll get that message in the log. Because getting a screenshot takes some time, I recommend disabling this option if you want to ensure that your ADB commands get executed quickly. Also, if you send |
Um.. I think It is fire TV's Problem. I tested with ADB server Directly, Right after turn on: after push some physical button: Do you have any idea? |
I found solution from googling :)
|
Here’s the change: #195 But I haven't tested it to see if it works. |
So this was the only issue, the current command used to launch an app wasn't working correctly? |
Yeah, like I said, if you don't press any button on remote controller, it doesn't work without being paired. |
I want to make sure that this change won't break any existing functionality before merging it. I tested that modified command on my Fire TV stick and it successfully launched Netflix. Then again, the current command works fine, also. FYI, if you use the following command via the
|
So when do you plan to merge? I look forward to using it in the next version. |
I merged it in, bumped the version, and updated the version in Home Assistant. |
I am trying to make some scripts on HA 0.114.0.dev0,
so, I'm using androidtv[async] 0.0.48 module.
The script didn't work as I wanted, so I looked into it.
And I guess there are some bugs on this project.
media_player.select_source service never work right after POWER adb command,
and the log is,
2020-08-07 23:32:53 INFO (MainThread) [homeassistant.components.androidtv.media_player] ADB command not executed because the connection is currently in use
In this situation, push any button on remote controller, after then select_source works again.
I think there will be a bug in the adb_manager_async.py related to _adb_lock, so please look for it.
The text was updated successfully, but these errors were encountered: