Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganize Dockerfiles / images #122

Open
jtagcat opened this issue Feb 13, 2022 · 0 comments · May be fixed by #130
Open

Reorganize Dockerfiles / images #122

jtagcat opened this issue Feb 13, 2022 · 0 comments · May be fixed by #130
Labels
enhancement New feature or request

Comments

@jtagcat
Copy link
Contributor

jtagcat commented Feb 13, 2022

https://docs.docker.com/develop/develop-images/multistage-build/#use-multi-stage-builds

  • As part of build, the api image should include the result of the current frontend image.
  • might be a good idea to split api and celeries
  • celeries should have a base image, and add to it with 2 separate images 
    FROM docker.io/JefferyCA/spleeter-web-celery-api
ENTRYPOINT ["celery-fast-entrypoint.sh"]
    ^ would be JefferyCA/spleeter-web-celery-fast
@jtagcat jtagcat linked a pull request Feb 13, 2022 that will close this issue
Open
@JeffreyCA JeffreyCA added the enhancement New feature or request label Feb 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

reform frontend out of Docker stuff + other Docker jtagcat/spleeter-web
2 participants
@JeffreyCA @jtagcat