-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support additional source separation models #19
Comments
I will prioritize adding the following models:
|
Hi Jeffrey! I recommend to postpone adding LaSAFT features. We are going to re-organize the code structure, aligned with the camera-ready version of the ICASSP 2021 paper (our paper was accepted to ICASSP 2021). It might cause conflicts. We'll also upload check-points of models trained on the larger scale (n_fft of 4096; currently we only support 2048). We will finish refactoring until March. Thank you. |
Hi @ws-choi, thanks for the update! I meant to comment earlier but I intend to only support models where the separated sources closely add up to the original source. Will your changes help with this? I'm not very familiar with these conferences so this is the first time hearing about ICASSP and it's being hosted in Toronto this year (although virtual)! Do you know what other conferences are there related to this research field? |
Will your changes help with this? => What other conferences are there related to this research field? => and other ML conferences such as Neurips, ICLR, ICML, AAAI, IJCAI, IJCNN and ECAI, |
Awesome, thanks! |
D3Net support is coming very soon! |
Would love to see LaSAFT! |
@JeffreyCA, Could you please add support for the kuielab MDX-Net models? both leaderboard A and leaderboard B? Model Comparison:
Could you also update the demucs installer to also include their hybrid model? |
Thanks for the suggestion, I'll check that out. The latest Spleeter Web already supports Demucs v3, which is the Hybrid version. |
Awesome! I'll look at the way you deploy your containers and try to follow the same structure. Here is a presentation that breaks down how it works: The readme was updated since I forked it: |
It's also a bit more complex as it requires Demucs 2, and Spleeter Web uses v3. |
I'll try to get an isolated container working for the default kuielab code, then I'll see if it will work with Demucs v3 by changing the requirements.txt to the latest demucs pip release. (I highly doubt that it'll be that easy, but I'll try nonetheless)
|
After further investigation, I found that mdx-net uses the Demucs v2 code but downloads the Demucs v3 model. It can be installed without conflict by using anaconda/miniconda. |
Can we have the Spleeter model with Piano (5 stems instead of 4)? |
@dts350z, I think that @JeffreyCA implemented the changes that you asked for: |
Please add Band-split RNN model! |
Summary of other models
The text was updated successfully, but these errors were encountered: