Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlap checkbox only prevents overlaps of the same sound. #6

Open
TheKrunch opened this issue Feb 14, 2021 · 1 comment
Open

Overlap checkbox only prevents overlaps of the same sound. #6

TheKrunch opened this issue Feb 14, 2021 · 1 comment

Comments

@TheKrunch
Copy link

When the "No Overlap" checkbox is checked, it only prevents the overlapping of the same sound file. If the user plays different sound files at the same time they will overlap each other. This seems to originate here:

AA-EE-OO/scripts.js

Lines 6 to 10 in 35e6ec8

if (document.getElementById("overlap").checked) {
document.getElementById(soundSrc).pause();
document.getElementById(soundSrc).currentTime = 0;
document.getElementById(soundSrc).play();
}

A sound file is only paused if it matches soundSrc. If a different file is already playing, the new soundSrc starts playing over it. I am not sure if is intended or not, but it seems to differ from the hover text explanation for the checkbox.

@sticks-stuff
Copy link
Member

i think someone told me to make it like that to match jermas soundboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants