Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance regression (audio) between new and old core #215

Open
6 of 11 tasks
SilentException opened this issue Jun 17, 2024 · 3 comments
Open
6 of 11 tasks

Performance regression (audio) between new and old core #215

SilentException opened this issue Jun 17, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@SilentException
Copy link

What version of melonDS DS are you using?

1.1.3

Does the problem happen in standalone melonDS?

I don't know.

What happened?

Using same settings (OpenGL and 5x resolution scale) there are frequent audio stutters and cutoffs with the new core. In the old one, there are hardly any. I uploaded two videos comparing the two and although the stutters are present throughout the video you can clearly hear the difference and errors in the last part of the video (10s+). This is with Mario Kart DS.

https://streamable.com/agqd8e (MelonDS DS)
https://streamable.com/yijm9d (MelonDS)

What should've happened instead?

Performance on par with old version :)

Which platforms do you see the problem on?

  • Windows
  • macOS
  • Linux
  • Android
  • iOS
  • tvOS
  • Other (specify below)

Which versions of the OS?

Steam OS 3.5.19

Which libretro frontend are you using?

Retroarch 1.19.1 Flatpak

Terms

  • I agree to follow the code of conduct.
  • I understand that melonDS DS is not developed or maintained by the authors of melonDS.
  • I understand that this form is for reporting bugs, not for requesting help.
  • I understand that the author develops this core in his spare time, and that he is under no obligation to respond to this bug report.
@SilentException SilentException added the bug Something isn't working label Jun 17, 2024
@JesseTG JesseTG modified the milestone: Update to the latest `master` Jun 26, 2024
@SilentException
Copy link
Author

Just a quick update, I updated the core to v1.1.7 but the performance has not improved.

@JesseTG
Copy link
Owner

JesseTG commented Oct 1, 2024

I'm working on cleaning up melonDS DS's integration with some profiling tools; would you be willing to take and upload a trace when I have that ready? It'll help me pin down where all the time is being spent each frame.

@SilentException
Copy link
Author

I'm working on cleaning up melonDS DS's integration with some profiling tools; would you be willing to take and upload a trace when I have that ready? It'll help me pin down where all the time is being spent each frame.

Sure thing, yea.
I was actually thinking of closing this and #226 as they both seem to be related to Rewind. Having Rewind off the performance is acceptable, similar or bit worse than old core and I also haven't experienced any freezes.
But I can test and upload a trace file, no problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

2 participants