-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kotlin changes are treated like Java code #122
Comments
Common question: is this plugin supposed to work with Kotlin code? I see very often suggestions for Java code, but this is the first time I see something for Kotlin |
@dimonchik0036 the plugin works with both Java and Kotlin, but it detects much more refactorings in Java code than in Kotlin. We plan to increase the number of refactorings the plugin is able to detect in Kotlin. In the case you described, the plugin correctly identified Rename method refactoring, right? And thank you for using the plugin! If you have any suggestions on how we can improve it or what features would be useful for you, please let us know! :) |
Yep. The diff is correct too. The issue is only about how it looks – it treats as Java (probably some misconfiguration bug): a color scheme from Java in the diff editor and Java icons in the log |
Hi @dimonchik0036, in the next release plugin will show icons depending on the file type (Kotlin icons for Kotlin files, Java icons for Java files). Thanks again for submitting the issue, I just didn't notice this before. About the color scheme in the editor -- could you please clarify if it changes the color scheme every time you open a file in the changes browser? Or only when you open refactoring visualization by double-clicking on the item in the list (when R button is selected)? |
Each language has its own color scheme. So Java files have one color, Kotlin files have another color. |
@dimonchik0036 Oh, I see, thank you! |
The diff from the plugin:
The original diff:
Even an icon came from Java:
The text was updated successfully, but these errors were encountered: