You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've noticed potential issues with the RefactoringHistoryToolbar:
New instance of VcsLogUi is created on every double click on the leaf node with RefactoringInfo, this is not good performance-wise.
Each time RefactoringHistoryAction is executed, new ui components are created, even though ui for the same element may exist already. RefactoringHistoryToolbar#showContent even finds the old content, but still replaces the old ui with the new one, instead of just refreshing it.
I think that that the code could be improved by extracting a class that represents one single tab with refactorings for a single element, let's call this RefactoringHistoryTab. This RefactoringHistoryTab would have one Tree instance, and one VcsLogUi (created on demand). The RefactoringHistoryAction would either find an existing RefactoringHistoryTab and focus it, or create a new one if nothing was found.
The text was updated successfully, but these errors were encountered:
I've noticed potential issues with the
RefactoringHistoryToolbar
:VcsLogUi
is created on every double click on the leaf node withRefactoringInfo
, this is not good performance-wise.RefactoringHistoryAction
is executed, new ui components are created, even though ui for the same element may exist already.RefactoringHistoryToolbar#showContent
even finds the old content, but still replaces the old ui with the new one, instead of just refreshing it.I think that that the code could be improved by extracting a class that represents one single tab with refactorings for a single element, let's call this
RefactoringHistoryTab
. ThisRefactoringHistoryTab
would have oneTree
instance, and oneVcsLogUi
(created on demand). TheRefactoringHistoryAction
would either find an existingRefactoringHistoryTab
and focus it, or create a new one if nothing was found.The text was updated successfully, but these errors were encountered: