Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions for improving RefactoringHistoryToolbar #58

Open
juliabeliaeva opened this issue Aug 28, 2020 · 0 comments
Open

Suggestions for improving RefactoringHistoryToolbar #58

juliabeliaeva opened this issue Aug 28, 2020 · 0 comments

Comments

@juliabeliaeva
Copy link
Contributor

I've noticed potential issues with the RefactoringHistoryToolbar:

  1. New instance of VcsLogUi is created on every double click on the leaf node with RefactoringInfo, this is not good performance-wise.
  2. Each time RefactoringHistoryAction is executed, new ui components are created, even though ui for the same element may exist already. RefactoringHistoryToolbar#showContent even finds the old content, but still replaces the old ui with the new one, instead of just refreshing it.

I think that that the code could be improved by extracting a class that represents one single tab with refactorings for a single element, let's call this RefactoringHistoryTab. This RefactoringHistoryTab would have one Tree instance, and one VcsLogUi (created on demand). The RefactoringHistoryAction would either find an existing RefactoringHistoryTab and focus it, or create a new one if nothing was found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant