Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to stop ProgressIndicator which is already stopped #375

Open
Vladislav0Art opened this issue Oct 7, 2024 · 0 comments
Open

Attempt to stop ProgressIndicator which is already stopped #375

Vladislav0Art opened this issue Oct 7, 2024 · 0 comments
Labels
bug Something isn't working UI/UX

Comments

@Vladislav0Art
Copy link
Collaborator

Describe the bug
Error occurred in ToolUtils.kt::isProcessCanceled when I tried to stop the test generation on compilation checking stage.

The problem may be in the line (**) (we should not can stop on a cancelled indicator):

 fun isProcessCanceled(indicator: CustomProgressIndicator): Boolean {
        if (indicator.isCanceled()) {
            indicator.stop() // (**)
            return true
        }
        return false
    }

To Reproduce
Steps to reproduce the behavior:

  1. Start generation for Kotlin;
  2. Click stop button on the indicator when "Compilation checking" occurs;
  3. See error

Expected behavior
Normal stop. No errors.

Additional context

2024-10-07 12:37:49,023 [ 212959] SEVERE - #c.i.o.p.u.AbstractProgressIndicatorBase - Attempt to stop ProgressIndicator which is already stopped: Generating tests 228899262: running=false; canceled=true; task=org.jetbrains.research.testspark.tools.Pipeline$runTestGeneration$1@7e83b9e0,class com.intellij.openapi.progress.impl.BackgroundableProcessIndicator
java.lang.IllegalStateException
	at com.intellij.openapi.progress.util.AbstractProgressIndicatorBase.throwInvalidState(AbstractProgressIndicatorBase.java:130)
	at com.intellij.openapi.progress.util.AbstractProgressIndicatorBase.stop(AbstractProgressIndicatorBase.java:118)
	at com.intellij.openapi.progress.util.AbstractProgressIndicatorExBase.stop(AbstractProgressIndicatorExBase.java:52)
	at com.intellij.openapi.progress.util.ProgressWindow.stop(ProgressWindow.java:285)
	at org.jetbrains.research.testspark.display.custom.IJProgressIndicator.stop(IJProgressIndicator.kt:32)
	at org.jetbrains.research.testspark.tools.ToolUtils.isProcessCanceled(ToolUtils.kt:117)
	at org.jetbrains.research.testspark.tools.ToolUtils.isProcessStopped(ToolUtils.kt:112)
	at org.jetbrains.research.testspark.tools.Pipeline$runTestGeneration$1.run(Pipeline.kt:107)
	at com.intellij.openapi.progress.impl.CoreProgressManager.startTask(CoreProgressManager.java:477)
	at com.intellij.openapi.progress.impl.ProgressManagerImpl.startTask(ProgressManagerImpl.java:133)
	at com.intellij.openapi.progress.impl.CoreProgressManager.lambda$runProcessWithProgressAsynchronously$6(CoreProgressManager.java:528)
	at com.intellij.openapi.progress.impl.ProgressRunner.lambda$submit$4(ProgressRunner.java:250)
	at com.intellij.openapi.progress.ProgressManager.lambda$runProcess$0(ProgressManager.java:100)
	at com.intellij.openapi.progress.impl.CoreProgressManager.lambda$runProcess$1(CoreProgressManager.java:221)
	at com.intellij.platform.diagnostic.telemetry.helpers.TraceKt.use(trace.kt:46)
	at com.intellij.openapi.progress.impl.CoreProgressManager.lambda$runProcess$2(CoreProgressManager.java:220)
	at com.intellij.openapi.progress.impl.CoreProgressManager.lambda$executeProcessUnderProgress$13(CoreProgressManager.java:660)
	at com.intellij.openapi.progress.impl.CoreProgressManager.registerIndicatorAndRun(CoreProgressManager.java:735)
	at com.intellij.openapi.progress.impl.CoreProgressManager.computeUnderProgress(CoreProgressManager.java:691)
	at com.intellij.openapi.progress.impl.CoreProgressManager.executeProcessUnderProgress(CoreProgressManager.java:659)
	at com.intellij.openapi.progress.impl.ProgressManagerImpl.executeProcessUnderProgress(ProgressManagerImpl.java:79)
	at com.intellij.openapi.progress.impl.CoreProgressManager.runProcess(CoreProgressManager.java:202)
	at com.intellij.openapi.progress.ProgressManager.runProcess(ProgressManager.java:100)
	at com.intellij.openapi.progress.impl.ProgressRunner.lambda$submit$5(ProgressRunner.java:250)
	at com.intellij.openapi.progress.impl.ProgressRunner$ProgressRunnable.run(ProgressRunner.java:500)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
	at java.base/java.util.concurrent.Executors$PrivilegedThreadFactory$1$1.run(Executors.java:702)
	at java.base/java.util.concurrent.Executors$PrivilegedThreadFactory$1$1.run(Executors.java:699)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:399)
	at java.base/java.util.concurrent.Executors$PrivilegedThreadFactory$1.run(Executors.java:699)
	at java.base/java.lang.Thread.run(Thread.java:840)
2024-10-07 12:37:49,026 [ 212962] SEVERE - #c.i.o.p.u.AbstractProgressIndicatorBase - IntelliJ IDEA 2024.1  Build #IC-241.14494.240
2024-10-07 12:37:49,026 [ 212962] SEVERE - #c.i.o.p.u.AbstractProgressIndicatorBase - JDK: 17.0.10; VM: OpenJDK 64-Bit Server VM; Vendor: JetBrains s.r.o.
2024-10-07 12:37:49,026 [ 212962] SEVERE - #c.i.o.p.u.AbstractProgressIndicatorBase - OS: Mac OS X
2024-10-07 12:37:49,026 [ 212962] SEVERE - #c.i.o.p.u.AbstractProgressIndicatorBase - Plugin to blame: TestSpark version: 0.2.1
2024-10-07 12:37:49,026 [ 212962] SEVERE - #c.i.o.p.u.AbstractProgressIndicatorBase - Last Action: SaveAll
2024-10-07 12:37:49,027 [ 212963] SEVERE - #c.i.o.p.u.AbstractProgressIndicatorBase - stop() should be called only if start() called before: Generating tests 228899262: running=false; canceled=true; task=org.jetbrains.research.testspark.tools.Pipeline$runTestGeneration$1@7e83b9e0,class com.intellij.openapi.progress.impl.BackgroundableProcessIndicator

Our code in the above trace is:

at org.jetbrains.research.testspark.display.custom.IJProgressIndicator.stop(IJProgressIndicator.kt:32)
	at org.jetbrains.research.testspark.tools.ToolUtils.isProcessCanceled(ToolUtils.kt:117)
	at org.jetbrains.research.testspark.tools.ToolUtils.isProcessStopped(ToolUtils.kt:112)
	at org.jetbrains.research.testspark.tools.Pipeline$runTestGeneration$1.run(Pipeline.kt:107)
@Vladislav0Art Vladislav0Art added bug Something isn't working UI/UX labels Oct 7, 2024
Vladislav0Art added a commit that referenced this issue Oct 7, 2024
The bug is reflected in the issue #375.
Vladislav0Art added a commit that referenced this issue Oct 10, 2024
The bug is reflected in the issue #375.
Vladislav0Art added a commit that referenced this issue Oct 10, 2024
…or a line (#344)

* fix update function

* create availableForGeneration

* ktlint

* feat: add javadoc for `JavaPsiHelper.availableForGeneration`

* feat: check for nullness of a PSI file in `TestSparkAction.update`

* feat: update javadocs in `PsiComponents.kt`

* feat: check for a class or method/func in `KotlinPsiHelper.availableForGeneration`

* feat: add TODO to `ToolUtils` about a potential bug

The bug is reflected in the issue #375.

* feat: make `PsiHelper.getSurroundingLineNumber` return 1-based line numbers

Before, the `KotlinPsiHelper` returned a 0-based line number which caused an issue with line-based test generation.
The generated prompt contained a line above the selected one.

* feat: implement line-based test generation with CUT as a context

When there is no surrounding method about the selected line,
we use the CUT as a context for this line. The CUT must always be present.
Otherwise, the generation action should have been disabled for this line.

* refactor: apply ktlint

* feat: add `See` in TODO

* feat: add TODO and surround $NAME in backticks in `linePrompt` template

* feat: collect class constructor signatures in `PsiClassWrapper`

* feat: remove backticks from `linePrompt`

* feat: fill line-based test generation with additional context

The line-based test generation that has a method as a context
of the line now also accepts constructors of the containing class.

* refactor: use `firstOrNull` for `cut` extraction

* refactor: apply ktlint

* fix: add required parameter to `ClassRepresentation` in tests

* publish: core module version `4.0.0`

The major version increased due to the change of the public API of `PromptGenerator.generatePromptForLine` method.

---------

Co-authored-by: Vladislav Artiukhov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working UI/UX
Projects
None yet
Development

No branches or pull requests

1 participant