You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
I ran TestSpark on a project A and received a test suite in the sidebar (I did not delete the sidebar). I closed the current project via pressing 'X' button on a mac window (notice that I did not close the IDE but a project within the same IDE instance!). I opened a different project and received the following warning:
This warning neither allows me to execute any subsequent generations nor does it terminate the previous generation if I click "Terminate". It is sort of soft deadlock. I can only re-open the IDE to fix this.
To Reproduce
Steps to reproduce the behavior:
Open a project A;
Generate tests and do not close the sidebar (idk whether it matters);
Close the project A;
Open a project B (A != B);
Attempt to generate tests in project B -> warning occurred -> try to terminate -> no-op -> soft deadlock.
Expected behavior
No soft deadlocks.
The text was updated successfully, but these errors were encountered:
The terminate button basically does nothing:
We just have a boolean value and we never keep track of the process. Se. we can either make the isRunning flag false again or perform a major refactoring how termination and process monitoring work
perform a major refactoring how termination and process monitoring work
I recommend trying to find a suitable solution that is least workload-demanding so as not to delay the release and create an issue for a major refactor "sometime later" after the release.
@Vladislav0Art I think I found an "acceptable" solution without major refactoring. In summary, with the more advanced indicator management that we have developed when extracting core module, can be very helpful here. So, we can actually check the indicator in the TestGenerationController instead of isRunning flag. Also, terminate can trigger the cancel() method from the indicator. I have made a PR here with this solution.
Describe the bug
I ran TestSpark on a project A and received a test suite in the sidebar (I did not delete the sidebar). I closed the current project via pressing 'X' button on a mac window (notice that I did not close the IDE but a project within the same IDE instance!). I opened a different project and received the following warning:
This warning neither allows me to execute any subsequent generations nor does it terminate the previous generation if I click "Terminate". It is sort of soft deadlock. I can only re-open the IDE to fix this.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
No soft deadlocks.
The text was updated successfully, but these errors were encountered: