Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelogs in plugin.xml and in Draft Release are different #371

Open
ris58h opened this issue Jun 8, 2023 · 3 comments
Open

Changelogs in plugin.xml and in Draft Release are different #371

ris58h opened this issue Jun 8, 2023 · 3 comments

Comments

@ris58h
Copy link

ris58h commented Jun 8, 2023

patchPluginXml Gradle task uses changes of the current version but Build workflow uses Unreleased changes.

Steps to reproduce:

  1. Have CHANGELOG.md with empty Unreleased section.
  2. Have pluginVersion Gradle property set to any release version in CHANGELOG.md except of Unreleased.
  3. Run workflows in .github/workflows/build.yml.

Expected behavior:
Changelogs in plugin.xml and in Draft Release are the same.

Additional context:
Changelogs in plugin.xml and in Draft Release are different.

@ris58h
Copy link
Author

ris58h commented Jun 21, 2023

It seems like all it's done later on release.
I only use build workflow without release workflow and I upload my plugin manually so it was confusing to me that a draft release doesn't contain an actual changes (and an artifact).

Anyway, being able to review an actual changes in a draft release would be useful.

@ciscorucinski
Copy link

It does seem to be process-specific and that can cause unexpected behavior. Maybe there could be a more process-agnostic approach?

@ris58h
Copy link
Author

ris58h commented Jun 22, 2023

I believe it's possible to make it more process-agnostic. I don't see why we shouldn't put an actual changelog in a draft release.

An artifact is a different thing and as I get from README there is a reason for not putting it in a draft release. May be we should introduce a settings to make it optional but it's a different question anyway and doesn't relate to the changelog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants