fix(installer): Fix the same pkgbase being built multiple times on error #2561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Classic, forgot to run the tests. Something's off here, I'll look into it. |
…error The previous fix commit ec837c8 failed to address the case where the build fails, as packages are only added to builtPkgDests on a successful build. This commit addresses this by adding the package to the map earlier. Fixes Jguer#2560.
Ferdi265
force-pushed
the
fix-pkgbase-multiple-failures
branch
from
7c152e3 to
2659e01
Compare
|
This should fix part of the test failures, I accidently used the wrong pkgdests when filling Yeah, it seems I don't know exactly how this should interact with the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous fix commit ec837c8 failed to address the case where the build fails, as packages are only added to builtPkgDests on a successful build. This commit addresses this by adding the package to the map earlier.
Fixes #2560.
The patch seems trivial and initial testing shows it works and I've not run into any issues with this patch yet, but I'll daily drive this for the next week anyway to see if anything comes up.