Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vlc paths for 64bit #229

Closed
omgbox opened this issue Aug 1, 2021 · 7 comments
Closed

vlc paths for 64bit #229

omgbox opened this issue Aug 1, 2021 · 7 comments
Assignees
Labels
bug Something isn't working CLI command-line interface related issues

Comments

@omgbox
Copy link

omgbox commented Aug 1, 2021

Describe the bug
user installed 64bit VLC there is a difference in path which is under C:\Program Files (x86)\VideoLAN\VLC\vlc.exe

To Reproduce
install 64bit and check path

Expected behavior
global path maybe to include 64 and 32 paths for vlc and maybe mpv path

Screenshots
vlc

Context:

  • OS: windows
  • Version: 64

Additional context
maybe include both 64 and 32 pathways for binary. optional to include mpv , allow user to save player pathway when saving profile.

@omgbox omgbox added the bug Something isn't working label Aug 1, 2021
@JiPaix
Copy link
Owner

JiPaix commented Aug 1, 2021

xdccJS piping isn't exclusive to VLC. Pathway are to be managed on your end (usually directly by your OS).
you'd either have to add VLC in your PATH config or put the whole path to the exe file:

xdccJS --host irc.server.net --bot "XDCC|BOT" --download 110 | "C:\Path\to\My\VLC.exe" -

@JiPaix JiPaix added the wontfix This will not be worked on label Aug 1, 2021
@JiPaix
Copy link
Owner

JiPaix commented Aug 1, 2021

If you need help with that follows this guide: https://www.architectryan.com/2018/03/17/add-to-the-path-on-windows-10/

@JiPaix JiPaix closed this as completed Aug 1, 2021
@omgbox
Copy link
Author

omgbox commented Aug 2, 2021

If you need help with that follows this guide: https://www.architectryan.com/2018/03/17/add-to-the-path-on-windows-10/

I have correctly added binary to path, but it seems that VLC is still not picking anything from fd:// , what might I be doing wrong any advice.
Untitled

@JiPaix
Copy link
Owner

JiPaix commented Aug 2, 2021

I have correctly added binary to path, but it seems that VLC is still not picking anything from fd:// , what might I be doing wrong any advice.

Nothing's wrong on your end, it appears using pipes with the CLI was broken, I released v4.2.7 on npmjs which fix this issue (along with #227).

You just need to update xdccJS

@JiPaix JiPaix added CLI command-line interface related issues and removed wontfix This will not be worked on labels Aug 2, 2021
@omgbox
Copy link
Author

omgbox commented Aug 3, 2021

it appears there might be some issue with setting up profiles, it seems to save the profile but it does not detect it
I have removed and reinstalled xdccjs with the same issue. streaming now works on vlc.
Untitled

@omgbox
Copy link
Author

omgbox commented Aug 3, 2021

keep downloading file even if vlc socket is closed . its not really important but would be nice as not to restart the same download.

sockets

@JiPaix
Copy link
Owner

JiPaix commented Aug 3, 2021

I opened issue #238 and #239 to discuss this matter.
Thanks for the feedback 👍

Repository owner locked as resolved and limited conversation to collaborators Aug 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working CLI command-line interface related issues
Projects
None yet
Development

No branches or pull requests

2 participants