Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dangling child process created by smartdnsblock are not terminated after disconnect #2247

Open
XCanG opened this issue Oct 17, 2024 · 3 comments
Labels
bug Something is broken, we are tracking it client os/windows question

Comments

@XCanG
Copy link

XCanG commented Oct 17, 2024

Application

Outline Client

Describe the bug

Every time I connect-disconnect Outline service spawn nested processes, however upon disconnecting it not properly terminate them, in the end console processes that runned in background keep running. For a short time usage where I use connection often during the day it keeps dozens of leftover processes hanging indefinitely. For more instructions look at the attached video.

Steps to reproduce

  1. Open the application
  2. Click connect
  3. Click disconnect
  4. Check processes

What did you expect to happen?

All opened processes will be closed on disconnect.

What actually happened?

Processes keep hanging indefinitely.

Outline Version

1.13.1 (476278)

What operation system are you using?

Windows

Operating System Version

Windows 10 x64 10.0.19043

Screenshots and Videos

Some of the processes not related to outline here, but I filtered them as I can, you can see that when I disconnect console processes moved to bottom and stack upon every disconnect.

2024-10-17_19-53-33_Outline.mp4
@XCanG XCanG added the bug Something is broken, we are tracking it label Oct 17, 2024
@jyyi1
Copy link
Contributor

jyyi1 commented Oct 23, 2024

Hi @XCanG , this is expected. The four Outline.exe process are all chromium processes (we will spawn the tun2socks.exe process during connection), and the OutlineService.exe will spawn a bunch of child processes as well (like the netsh command and the smartdnsblock).

OutlineService.exe is a Windows service that is expected to run 24/7, otherwise Outline Client will fail to connect.

@jyyi1 jyyi1 added needs more info We need more information in order to help or verify os/windows client question and removed bug Something is broken, we are tracking it labels Oct 23, 2024
@XCanG
Copy link
Author

XCanG commented Oct 24, 2024

Did you check the video? An infinitely increasing processes is a bug, those processes isn't used for a new connection that created later.

Also I have nothing against service, it just not clean up processes properly on disconnect.

@jyyi1
Copy link
Contributor

jyyi1 commented Oct 29, 2024

I see. You are saying the child processes created by smartdnsblock, we terminated the parent one but the child process remains dangling.

@jyyi1 jyyi1 added bug Something is broken, we are tracking it and removed needs more info We need more information in order to help or verify labels Oct 29, 2024
@jyyi1 jyyi1 changed the title [Bug]: Outline service keep hanging console processes indefinitely until service restarted (Windows) Dangling child process created by smartdnsblock are not terminated after disconnect Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken, we are tracking it client os/windows question
Projects
None yet
Development

No branches or pull requests

2 participants