Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

how about adding cli? #80

Open
elvizlai opened this issue Oct 27, 2024 · 7 comments
Open

how about adding cli? #80

elvizlai opened this issue Oct 27, 2024 · 7 comments
Labels
enhancement New feature or request

Comments

@elvizlai
Copy link

elvizlai commented Oct 27, 2024

Is your feature request related to a problem?/你的请求是否与某个问题相关?

sometime cli mod can adding hook target by command line, which is very useful.
like: https://github.com/mywalkb/LSPosed_mod/wiki/CLI

Please take a look and think about it, thanks.

Describe the solution you'd like/描述你想要的解决方案

add cli

Additional context/其他信息

No response

@elvizlai elvizlai added the enhancement New feature or request label Oct 27, 2024
@JingMatrix
Copy link
Owner

Well, not really feeling that it is very useful. We can wait for other users' opinions, of course.

@MmyGgithubAaccount
Copy link

I moved to lsposed_mod precisely because of the cli so I can disable individual lsposed modules without needing to disable lsposed itself in case of systemui crash caused by a module

Although the way it is implemented in that fork is that it needs to boot into system first to access cli so you need to be quick to do whatever changes you need as soon as adb is enabled and before the systemui crash loop forces another reboot

@JingMatrix
Copy link
Owner

@MmyGgithubAaccount In your described situtation, you could simply disable the Zygisk - LSPosed module directly.

@MmyGgithubAaccount
Copy link

MmyGgithubAaccount commented Nov 8, 2024

Yes, that's what I want to avoid as doing that would uninstall all modified apps that I have installed (by disabling signature verification)
And iirc disabling lsposed would also disable all modules so I will have to reboot twice to enable them again (three if you count the reboot required to disable lsposed as I don't run twrp). Plus I've had instances where the order in which lsposed modules are enabled affect how they work so I have to keep a note of that as well which is another hassle

Tldr disabling lsposed is an option but it would require me to remember and setup a lot of stuff again to get back to the same working state and I'm lazy

Edit: to be clear I've only needed to use the cli this way twice to rescue my system so it is not a common occurrence. But having a fallback option is pretty nice to have

@JingMatrix
Copy link
Owner

JingMatrix commented Nov 8, 2024

Why disable LSPosed will imply the following?

  1. uninstall all modified apps
  2. change the order of modules taking effects

All of them are saved in database, and simply disabling a module won't change them at all.

@MmyGgithubAaccount
Copy link

  1. Modified apps are installed on top of originals by disabling signature verification using lsposed. Disabling lsposed would also disable that
  2. I'm might be misremembering the disabling modules part, but I think the modules got disabled for me once/twice. It might be because of booting into safe mode or rescue party trigger. It happened long ago so not sure about the details

My main point was that cli would allow disabling buggy modules without turning off other lsposed modules which I want turned on 24/7

@JingMatrix
Copy link
Owner

JingMatrix commented Nov 8, 2024

If an modified app is installed by tricking the normal signature verification, then it will keep installed even if you disable CorePatch (I guess you are using this module).

If modules get disabled, that could be caused by safe mode, which is not your described situation.

It is not common that users have buggy modules that frequently breaks their system UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants