Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One click download #24

Open
MartijnCuppens opened this issue Sep 27, 2018 · 7 comments
Open

One click download #24

MartijnCuppens opened this issue Sep 27, 2018 · 7 comments
Labels
enhancement New feature or request

Comments

@MartijnCuppens
Copy link
Collaborator

I don't think the modal has an added value, shouldn't we just add a loading state to the build-button and rename it to download?

@Johann-S
Copy link
Owner

The value I see in the modal, it's it disable inputs thanks to the backdrop so if we remove the modal we should disable all the checkbox during the build 🤔

@MartijnCuppens
Copy link
Collaborator Author

We could add an overlay over the form? or add pointer-events: none to to form?

@Johann-S
Copy link
Owner

Plus I like the modal because we can display some text which explain what we are doing (that's an improvement I have in mind since the beginning), for example : Downloading files --> Building files --> Minifying --> Ready

I think it's important to give a lot of information about what we're doing to the user, so if you have any idea how to do that with or without a modal, do not hesitate 👍

@MartijnCuppens
Copy link
Collaborator Author

We can display this in or below the button? The thing that "bothers" me is that I need to click, wait and click again to download the file.

@MartijnCuppens
Copy link
Collaborator Author

The behaviour I prefer is something more like the old customizer:
https://getbootstrap.com/docs/3.3/customize/#download

@Johann-S
Copy link
Owner

Ok I understand, more clicks 😟

Feel free to push a PR about that 👍

@XhmikosR
Copy link
Collaborator

Yeah, I agree. This should be simpler for sure. We could inject any info below the buttons if needed.

@Johann-S Johann-S added the enhancement New feature or request label Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants