Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance issues VSC extension on version newer than 1.31.1 #720

Open
RuizuKun-Dev opened this issue Jul 26, 2024 · 4 comments
Open

Performance issues VSC extension on version newer than 1.31.1 #720

RuizuKun-Dev opened this issue Jul 26, 2024 · 4 comments
Labels
performance Performance issues with the language server

Comments

@RuizuKun-Dev
Copy link

I'm having issues with versions newer than 1.31.1, meaning version 1.31.1 has no issue but 1.32.0 and above do

image

Whenever i type something it doesn't update properly and sometimes even crashes

@RuizuKun-Dev RuizuKun-Dev changed the title Performance issues Luau-LSP extension in VSC with version greater than 1.31.1 Performance issues VSC extension on version newer than 1.31.1 Jul 26, 2024
@JohnnyMorganz
Copy link
Owner

Please provide some reproduction steps since unforunately there is not much I can do to diagnose this otherwise

@RuizuKun-Dev
Copy link
Author

RuizuKun-Dev commented Aug 14, 2024

Please provide some reproduction steps since unforunately there is not much I can do to diagnose this otherwise

that's really tough because for me it always happens no matter what i do here's a video

Code_25TRL0kPlg.mp4

I'm on version 1.32.3

I keep getting this too whenever i have to reload Luau-LSP and when opening VS Code

image

@JohnnyMorganz
Copy link
Owner

I plan on taking a deeper look at LSP performance issues. Can you generate a trace.json file and send it to me when you experience slowdowns? You will need to use a nightly build, but the steps are:

  1. Download the latest nightly from https://github.com/JohnnyMorganz/luau-lsp/actions/workflows/nightly.yml for your platform. It will contain an archive for your platform. Download and extract, and you'll find a .vsix file inside. Install this into VSCode
  2. Launch VSCode and enable the FFlag DebugLuauTimeTracing
  3. Reload your window
  4. Perform your work as normal
  5. Run Luau: Flush Time Tracing Events to tracing.json command to write out a JSON file

This JSON file can be loaded into a visualiser such as chrome://tracing or Perfetto.

This will help to pinpoint the performance issues

@JohnnyMorganz JohnnyMorganz added the performance Performance issues with the language server label Nov 10, 2024
@RuizuKun-Dev
Copy link
Author

yep, i'll do that for you when i get the chance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance issues with the language server
Projects
None yet
Development

No branches or pull requests

2 participants