feat: display no extension banner on streaming payments page #4120
Conversation
| const isStreamingPaymentsInstalled = | ||
| extensionData && isInstalledExtensionData(extensionData); | ||
|
|
||
| const inStreamingPaymentsDisabled = |
There was a problem hiding this comment.
Tiny spelling mistake: isStreamingPaymentsDisabled
(You might already have it, but just in case, I use this spell checker VS Code extension which helps me catch issues like this all the time! https://marketplace.visualstudio.com/items?itemName=streetsidesoftware.code-spell-checker )
There was a problem hiding this comment.
Hey @adam-strzelec nice start on this issue 🙌
The banner looks great ✨
I left a few refactoring comment, if you could have a look over them, I'd totally appreciate it 👍
| <a href={`${COLONY_EXTENSIONS_ROUTE}/${Extension.StreamingPayments}`}> | ||
| {formatMessage(MSG.link)} | ||
| </a> |
There was a problem hiding this comment.
By using the <a> tag, we're going to trigger a whole-page reload
Screen.Recording.2025-01-17.at.12.32.30.mov
Let's refactor this and use the Link component.
Also for the extension url we could use const { extensionUrl } = useExtensionItem(Extension.StreamingPayments);
| const isStreamingPaymentsInstalled = | ||
| extensionData && isInstalledExtensionData(extensionData); |
There was a problem hiding this comment.
I believe this piece of code can be easily refactored to use
const { isExtensionInstalled } = useExtensionItem(
Extension.StreamingPayments,
);
Given it performs already all these checks to verify if the extension was or not installed.
| extensionData && isInstalledExtensionData(extensionData); | ||
|
|
||
| const inStreamingPaymentsDisabled = | ||
| !!extensionData && !isStreamingPaymentsInstalled; |
There was a problem hiding this comment.
Do we actually need to check if extensionData exists?
adam-strzelec
force-pushed
the
feat/streaming-payments-ui
branch
from
6196803 to
af9aebd
Compare
There was a problem hiding this comment.
@adam-strzelec Thank you for the PR, the banner looks good. Although, it does not fully meet the issue without the "Create new stream" button.
Also, the banner should show when the extension is in a deprecated state as well. At the moment, it only shows if the extension is not installed.
Not Installed
Deprecated
|
@adam-strzelec this branch needs a rebase before I can drop another review 🙌 |
adam-strzelec
force-pushed
the
feat/16237055-display-no-extension-banner
branch
from
29c1854 to
7aeb3f8
Compare
|
@arrenv Is there a design somewhere that shows what the banner should look like when the extension is deprecated? |
Sure, the banner and design accounts for both cases. The message says "Streaming payments extension is currently not enabled." So, when it is not installed or deprecated, then that means it is not enabled. |
Description
Display banner info about no extension installed on streaming payments page if extension is not installed
Testing
Diffs
New stuff ✨
Changes 🏗
Resolves #4096