-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Goerli from codebase #1314
base: develop
Are you sure you want to change the base?
Conversation
@area do you have the |
Are any of those still supported? I'm not sure if we ever ended up on ropsten or kovan. |
Noting that we are on Arbitrum-Sepolia but not the other testnets, at |
58c00ec
to
5ee863a
Compare
@area do the docs need to be updated to go from Ethereum Also, do we need to migrate off of https://docs.metamask.io/services/reference/arbitrum/quickstart/#ethers |
I don't see why we shouldn't, I'm always going to be pro-keeping-docs-up-to-date.
That doesn't seem to be the case?. I'd be more than happy to regardless though as you can just pass an Infura endpoint to a 'normal' |
2fb750c
to
1494445
Compare
Will review this tomorrow |
@@ -119,7 +119,7 @@ The oracle should be able to provide responses to any valid reputation score in | |||
For example, you can get the reputation score of the miner in a reputation state `0xc7eb2cf60aa4848ce0feed5d713c07fd26e404dd50ca3b9e4f2fabef196ca3bc`) using the address of the Meta Colony (`0x14946533cefe742399e9734a123f0c02d0405a51`), the mining skill id (`2`), and address of a miner (`0x0A1d439C7d0b9244035d4F934BBF8A418B35d064`). | |||
|
|||
``` | |||
https://xdai.colony.io/reputation/mainnet/0xc7eb2cf60aa4848ce0feed5d713c07fd26e404dd50ca3b9e4f2fabef196ca3bc/0x14946533cefe742399e9734a123f0c02d0405a51/2/0x0A1d439C7d0b9244035d4F934BBF8A418B35d064 | |||
https://xdai.colony.io/reputation/arbitrum/0xc7eb2cf60aa4848ce0feed5d713c07fd26e404dd50ca3b9e4f2fabef196ca3bc/0x14946533cefe742399e9734a123f0c02d0405a51/2/0x0A1d439C7d0b9244035d4F934BBF8A418B35d064 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The slug in the middle should be arbitrum-one
, and the subdomain should be app
. It would also be nice if the parameters chosen for the example returned a valid reputation proof, rather than getting a 'no such state' error.
Closes #1219