Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utils header is missing #2

Open
ivan-pi opened this issue May 11, 2023 · 3 comments
Open

Utils header is missing #2

ivan-pi opened this issue May 11, 2023 · 3 comments

Comments

@ivan-pi
Copy link

ivan-pi commented May 11, 2023

~/compbiomed/HemePure_tools$ find . -name utils.h
~/compbiomed/HemePure_tools$ 
[ 95%] Building CXX object CMakeFiles/voxelizer.dir/voxelizer/source/voxelizer_MultiInput.cpp.o
/Users/di75yas/compbiomed/HemePure_tools/voxelizer/source/voxelizer_MultiInput.cpp:12:10: fatal error: utils.h: No such file or directory
   12 | #include "utils.h"
      |          ^~~~~~~~~
compilation terminated.
make[2]: *** [CMakeFiles/voxelizer.dir/voxelizer/source/voxelizer_MultiInput.cpp.o] Error 1
make[1]: *** [CMakeFiles/voxelizer.dir/all] Error 2
make: *** [all] Error 2

@ivan-pi
Copy link
Author

ivan-pi commented May 22, 2023

It doesn't seem to be a TIRPC header:

~/Downloads/libtirpc-1.3.3$ find . -name "utils.h"
~/Downloads/libtirpc-1.3.3$ 

I will try to comment it out, and see which symbols are missing then.

@ivan-pi
Copy link
Author

ivan-pi commented May 22, 2023

If I had to make a guess it would be one of these:

~/compbiomed/HemePure_tools$ find . -name "utils.h"
./build/palabos/externalLibraries/nanoflann/utils.h
./build/palabos/jlabos/src/plbWrapper/utils/utils.h

The jlabos folder is a Java wrapper of Palabos, so it feels kind of irrelevant here.

Okay, judging by this line in the Makefile which calls Scons:

# Path to inlude directories (other than Palabos)
includePaths = ../palabos/externalLibraries/nanoflann

the utils.h is from nanoflann.

@ivan-pi
Copy link
Author

ivan-pi commented May 22, 2023

It appears like this header is unused in the voxelizer_MultiInput.cpp variant anyways, so the line could be simply deleted. If needed, e.g. in voxelizer.cpp.nanoflann sourcefile, it may be sensible to replace it with:

#include "nanoflann/utils.h"

to have at-least some provenance documented. The Makefile also needs to be adjusted in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant