Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename ReadPrintFileContentsNode to ReadFileNode #229

Open
milesfrain opened this issue Aug 26, 2020 · 1 comment
Open

Rename ReadPrintFileContentsNode to ReadFileNode #229

milesfrain opened this issue Aug 26, 2020 · 1 comment
Assignees
@milesfrain
Labels
cookbook Issues related to this repo as a whole and not a recipe in particular

Comments

@milesfrain
Copy link
Collaborator

I think the proposed name is descriptive enough. It also compliments the existing WriteFileNode recipe.

This recipe is also a suggested template, so contributing.md will need to be updated too.
@milesfrain milesfrain added the cookbook Issues related to this repo as a whole and not a recipe in particular label Aug 26, 2020
@JordanMartinez
Copy link
Owner

I'm good with this change. The name is already quite long.

@milesfrain milesfrain self-assigned this Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@milesfrain milesfrain

Labels
cookbook Issues related to this repo as a whole and not a recipe in particular
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@milesfrain @JordanMartinez