Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Complex folder structure search #38

Open
tirphana opened this issue Jan 2, 2022 · 2 comments
Open

[Feature request] Complex folder structure search #38

tirphana opened this issue Jan 2, 2022 · 2 comments
Assignees

Comments

@tirphana
Copy link

tirphana commented Jan 2, 2022

First off, huge thanks for all the work on this addon, it really is a life-saver and a time-saver in many ways.

Now, my question is, would it be possible to implement a search function that encompasses folder structures with subdirectories nested several levels deep that might also have overlapping names? E.g. say I have a bookmark folder ham/eggs/waldo/foo/bar and then more than one with similar names, say, spam/eggs/fred/foo/bar and want to save different new bookmarks to a seperate one from these by typing the path to the bookmark folder, for as of now the search menu just gets confused and throws random folder suggestions to me.

@JoseTomasTocino
Copy link
Owner

Thanks for the request! Let me try to understand what you need. Say we have the following structure, as you suggested:

image

If I use the extension to look for the foo folder, two entries appear:

image

So you need a way of identifying each entry by, for example, adding a prefix or something. Is that right? In that case, I think we could use the forward slash to mark the hierarchy, something similar to how xpath works. For example, in the case above, I would address the ham/eggs/waldo/foo/bar folder by using waldo/foo, or a partial match like wal/foo.

Would that work for you?

@tirphana
Copy link
Author

tirphana commented Jan 14, 2022

Sorry for the late reply, I was too busy last couple of days unfortunately. I think I could've used a better example previously, so consider this one (I only opened the first tree for less taken space, all subfolders have the same structure):

bookmark_structure_lalala

And the suggestions I get are all over the place, with no way to figure out which is the correct one I want in a given case. And even though one can use the - to indicate the directory above, it still doesn't serve much purpose in cases such as the one I mentioned above:

suggestions

I think we could use the forward slash to mark the hierarchy

That is indeed what I was going for, it would make the most amount of sense, if possible to implement.

Edit: My bad for not going through existing issues earlier, I just realised yphastos already suggested something similar a few years ago in #11 , feel free to close this if you wish so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants