You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This would help us to avoid sending unnecessary props through to native. If a prop is set that is not recognised by the ViewInstance type we should avoid calling through to __BlueprintNative__.setViewProperty.
This is motivated after hitting a bug in which passing through a mobx-state-tree model as a prop caused Duktape/EcmascriptEngine to fall over (likely due to some sort of object cycle).
The text was updated successfully, but these errors were encountered:
We should ad prop whitelisting/validation in
BlueprintBackend.setProperty
: https://github.com/nick-thompson/blueprint/blob/master/packages/react-juce/src/lib/BlueprintBackend.ts#L149This would help us to avoid sending unnecessary props through to native. If a prop is set that is not recognised by the
ViewInstance
type we should avoid calling through to__BlueprintNative__.setViewProperty
.This is motivated after hitting a bug in which passing through a
mobx-state-tree
model as a prop caused Duktape/EcmascriptEngine to fall over (likely due to some sort of object cycle).The text was updated successfully, but these errors were encountered: