-
-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Hermes debugger support #240
Comments
Turns out we'll need to implement the chrome debug/inspector protocol as is done in ReactNative so this will be a non-trivial integration. See: facebook/hermes#486 |
FYI I tried react-dev-tools and it works (sometime it's buggy and too old version of react-juce). update: https://docs.google.com/presentation/d/1F-Fpp_nRZRTSsvWRra41AH5smLbJGOFShcSluUs577Q/edit?usp=sharing |
@zigen ahh that's awesome! I'll take a look over your branch and try to digest some of this. |
@zigen you're a hero 🙏 ! I haven't looked to closely at your code yet, but at a quick first pass this seems very much like something we could integrate upstream here |
Thanks for quick replies! When I tried, I was so confused because there're few document about react-devtools, so I drew a sketch. https://docs.google.com/presentation/d/1F-Fpp_nRZRTSsvWRra41AH5smLbJGOFShcSluUs577Q/edit?usp=sharing |
Hermes supports the chrome debugger protocol along with some profiling tools. Lets see how far we can take this. Can we get react-dev-tools working for example ...
Should ideally work using the same experience as the current Duktape debug integration, i.e. CMD-D starts the debugger and awaits client attach.
The text was updated successfully, but these errors were encountered: