Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Hermes debugger support #240

Open
JoshMarler opened this issue Feb 16, 2021 · 5 comments
Open

Implement Hermes debugger support #240

JoshMarler opened this issue Feb 16, 2021 · 5 comments
Assignees
Milestone

Comments

@JoshMarler
Copy link
Owner

Hermes supports the chrome debugger protocol along with some profiling tools. Lets see how far we can take this. Can we get react-dev-tools working for example ...

Should ideally work using the same experience as the current Duktape debug integration, i.e. CMD-D starts the debugger and awaits client attach.

@JoshMarler JoshMarler self-assigned this Feb 16, 2021
@JoshMarler JoshMarler added this to the beta milestone Mar 19, 2021
@JoshMarler JoshMarler reopened this Mar 19, 2021
@JoshMarler
Copy link
Owner Author

Turns out we'll need to implement the chrome debug/inspector protocol as is done in ReactNative so this will be a non-trivial integration.

See: facebook/hermes#486

@zigen
Copy link
Contributor

zigen commented Apr 9, 2021

FYI I tried react-dev-tools and it works (sometime it's buggy and too old version of react-juce).
I hope this will help you.
zigen/blueprint@7d5d776...devtools

update:
I found a screenshot and I draw the slide to describe the internal architecture
Screen Shot 2020-11-02 at 0 17 09

https://docs.google.com/presentation/d/1F-Fpp_nRZRTSsvWRra41AH5smLbJGOFShcSluUs577Q/edit?usp=sharing

@JoshMarler
Copy link
Owner Author

@zigen ahh that's awesome! I'll take a look over your branch and try to digest some of this. react-dev-tools isn't something I know a huge amount about but I'd love to see it available for profiling render cycles etc.

@nick-thompson
Copy link
Collaborator

@zigen you're a hero 🙏 ! I haven't looked to closely at your code yet, but at a quick first pass this seems very much like something we could integrate upstream here

@zigen
Copy link
Contributor

zigen commented Apr 9, 2021

Thanks for quick replies!
If I have a time, I want to merge into upstream, but perhaps I will be busy.
Anyone can copy/edit my code as you need.

When I tried, I was so confused because there're few document about react-devtools, so I drew a sketch.
now I remember it and rewrite it as a google slide.
If you have a question, please ask here or comment to my slides

https://docs.google.com/presentation/d/1F-Fpp_nRZRTSsvWRra41AH5smLbJGOFShcSluUs577Q/edit?usp=sharing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants